From: <jes@trained-monkey.org>
To: bcollins@debian.net
Cc: torvalds@transmeta.com, alan@redhat.com, linux-kernel@vger.kernel.org
Subject: [patch] 64 bit locking in ieee1394/nodemgr.c
Date: Thu, 16 Aug 2001 00:39:03 -0400 [thread overview]
Message-ID: <200108160439.f7G4d3b19502@savage.trained-monkey.org> (raw)
Hi
The drivers/ieee1394/nodemgr.c driver tries to save cpu_flags in a 32
bit type which is kinda bad.
Here is a patch.
Jes
--- drivers/ieee1394/nodemgr.c~ Wed Aug 8 00:08:04 2001
+++ drivers/ieee1394/nodemgr.c Thu Aug 16 00:37:15 2001
@@ -208,7 +208,7 @@
nodeid_t nodeid = LOCAL_BUS;
quadlet_t buffer[5], quad;
octlet_t base = CSR_REGISTER_BASE + CSR_CONFIG_ROM;
- int flags;
+ unsigned long flags;
/* We need to detect when the ConfigROM's generation has changed,
* so we only update the node's info when it needs to be. */
@@ -389,7 +389,7 @@
static void nodemgr_add_host(struct hpsb_host *host)
{
struct host_info *hi = kmalloc (sizeof (struct host_info), GFP_KERNEL);
- int flags;
+ unsigned long flags;
if (!hi) {
HPSB_ERR ("Out of memory in Node Manager");
@@ -416,7 +416,7 @@
{
struct list_head *lh;
struct host_info *hi = NULL;
- int flags;
+ unsigned long flags;
spin_lock_irqsave (&host_info_lock, flags);
lh = host_info_list.next;
@@ -451,7 +451,7 @@
struct list_head *lh;
struct host_info *hi = NULL;
struct node_entry *ne;
- int flags;
+ unsigned long flags;
/* First remove all node entries for this host */
write_lock_irqsave(&node_lock, flags);
next reply other threads:[~2001-08-16 4:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-16 4:39 jes [this message]
2001-08-16 5:11 ` Ben Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108160439.f7G4d3b19502@savage.trained-monkey.org \
--to=jes@trained-monkey.org \
--cc=alan@redhat.com \
--cc=bcollins@debian.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®