From: <jes@trained-monkey.org>
To: Peter Schlaile <udbz@rz.uni-karlsruhe.de>
Cc: torvalds@transmeta.com, alan@redhat.com, linux-kernel@vger.kernel.org
Subject: [patch] 64 bit bug in video1394.c
Date: Thu, 16 Aug 2001 00:47:01 -0400 [thread overview]
Message-ID: <200108160447.f7G4l1P19532@savage.trained-monkey.org> (raw)
Hi
drivers/ieee1394/video1394.c has a couple of instances where it saved
cpu flags in 'int' which breaks on 64 bit boxes.
Here's a patch.
Jes
--- drivers/ieee1394/video1394.c~ Wed Aug 8 00:08:04 2001
+++ drivers/ieee1394/video1394.c Thu Aug 16 00:46:13 2001
@@ -1283,7 +1283,8 @@
{
struct video_card *video = NULL;
struct ti_ohci *ohci;
- int res = -EINVAL, flags;
+ int res = -EINVAL;
+ unsigned long flags;
struct list_head *lh;
spin_lock_irqsave(&video1394_cards_lock, flags);
@@ -1320,7 +1321,8 @@
static int video1394_open(struct inode *inode, struct file *file)
{
- int i = MINOR(inode->i_rdev), flags;
+ int i = MINOR(inode->i_rdev);
+ unsigned long flags;
struct video_card *video = NULL;
struct list_head *lh;
@@ -1350,7 +1352,8 @@
struct video_card *video = NULL;
struct ti_ohci *ohci;
u64 mask;
- int i, flags;
+ int i;
+ unsigned long flags;
struct list_head *lh;
spin_lock_irqsave(&video1394_cards_lock, flags);
@@ -1416,7 +1419,8 @@
void irq_handler(int card, quadlet_t isoRecvIntEvent,
quadlet_t isoXmitIntEvent)
{
- int i, flags;
+ int i;
+ unsigned long flags;
struct video_card *video = NULL;
struct list_head *lh;
@@ -1465,7 +1469,7 @@
static int video1394_init(struct ti_ohci *ohci)
{
struct video_card *video = kmalloc(sizeof(struct video_card), GFP_KERNEL);
- int flags;
+ unsigned long flags;
char name[16];
if (video == NULL) {
@@ -1525,7 +1529,8 @@
/* Must be called under spinlock */
static void remove_card(struct video_card *video)
{
- int i, flags;
+ int i;
+ unsigned long flags;
ohci1394_unregister_video(video->ohci, &video_tmpl);
@@ -1556,7 +1561,7 @@
static void video1394_remove_host (struct hpsb_host *host)
{
struct ti_ohci *ohci;
- int flags;
+ unsigned long flags;
struct list_head *lh;
/* We only work with the OHCI-1394 driver */
next reply other threads:[~2001-08-16 4:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-16 4:47 jes [this message]
2001-08-16 4:49 jes
2001-08-16 5:08 ` Jeff Chua
2001-08-16 4:53 jes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108160447.f7G4l1P19532@savage.trained-monkey.org \
--to=jes@trained-monkey.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=udbz@rz.uni-karlsruhe.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®