mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>
To: ionut@cs.columbia.edu, alan@lxorguk.ukuu.org.uk (Alan Cox),
	linux-kernel@vger.kernel.org (kernel list)
Subject: Re: [PATCH] allow hdX=scsi when ide-scsi is a module
Date: Tue, 21 Aug 2001 00:14:18 +0200 (CEST)	[thread overview]
Message-ID: <200108202214.AAA09066@green.mif.pg.gda.pl> (raw)

> The current IDE code doesn't allow the user to reserve a drive to be used 
> only with ide-scsi emulation, if the ide-scsi layer is compiled as a 
> module. The following trivial patch fixes the problem, I've been using it 
> for the last 6 months or so.
> 
> The patch removes the explicit dependency on CONFIG_SCSI because ide-scsi 
> itself requires the SCSI subsystem.

Even worse.
As the following legal steps:

CONFIG_BLK_DEV_IDESCSI=y
CONFIG_SCSI=y
    |
    V
make config
    |
    V
  SCSI emulation support (CONFIG_BLK_DEV_IDESCSI) [Y/m/n/?] y
  ...
  SCSI support (CONFIG_SCSI) [Y/m/n/?] m
    |
    V
CONFIG_BLK_DEV_IDESCSI=y
CONFIG_SCSI=m

result in an invalid configuration.
So I suggest also the following change:
**********************************************************
--- drivers/ide/ide.c.old	Mon Aug 20 23:03:11 2001
+++ drivers/ide/ide.c	Mon Aug 20 23:03:39 2001
@@ -3452,7 +3452,7 @@
  #ifdef CONFIG_SCSI
 	(void) idescsi_init();
  #else
-    #warning ide scsi-emulation selected but no SCSI-subsystem in kernel
+    #error ide scsi-emulation selected but no SCSI-subsystem in kernel
  #endif
 #endif /* CONFIG_BLK_DEV_IDESCSI */
 }



BTW, IDE config is broken in much more places :(

Andrzej
-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk

             reply	other threads:[~2001-08-20 22:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-20 22:14 Andrzej Krzysztofowicz [this message]
2001-08-21 14:03 ` Ion Badulescu
  -- strict thread matches above, loose matches on Subject: below --
2001-08-20 16:28 Ion Badulescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200108202214.AAA09066@green.mif.pg.gda.pl \
    --to=ankry@green.mif.pg.gda.pl \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ionut@cs.columbia.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®