mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: igloo@earth.li (Ian Lynagh)
Cc: linux-kernel@vger.kernel.org
Subject: Re: Problems with corruption sending packets from a module
Date: Tue, 21 Aug 2001 02:57:08 +0400 (MSD)	[thread overview]
Message-ID: <200108202257.CAA00748@mops.inr.ac.ru> (raw)
In-Reply-To: <20010820170424.A713@stu163.keble.ox.ac.uk> from "Ian Lynagh" at Aug 20, 1 09:15:01 pm

Hello!

> In case someone is reading the archives and has a similar problem, this
> appears to be the cause of the trouble. If I do
> skb->data += sizeof(struct ethhdr);
> then it's fine. 

It is not fine at all... You are not allowed to change skb->data,
skb->len etc.


>	I guess I ought to be using skb_reserve really

You guess right: skb_reserve(), skb_put() and other functions
provided by skbuff.h. But not to touch pointers directly,
they have dependancies, which are known only to skbuff.[hc].

Alexey

       reply	other threads:[~2001-08-21 18:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20010820170424.A713@stu163.keble.ox.ac.uk>
2001-08-20 22:57 ` Alexey Kuznetsov [this message]
2001-08-21 18:47   ` Ian Lynagh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200108202257.CAA00748@mops.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=igloo@earth.li \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®