From: Daniel Phillips <phillips@bonn-fries.net>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: tommy@teatime.com.tw, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Memory Problem in 2.4.9 ?
Date: Thu, 23 Aug 2001 04:29:12 +0200 [thread overview]
Message-ID: <20010823022243Z16060-32383+932@humbolt.nl.linux.org> (raw)
In-Reply-To: <Pine.LNX.4.21.0108222103261.2685-100000@freak.distro.conectiva>
In-Reply-To: <Pine.LNX.4.21.0108222103261.2685-100000@freak.distro.conectiva>
On August 23, 2001 02:10 am, Marcelo Tosatti wrote:
> On Thu, 23 Aug 2001, Daniel Phillips wrote:
>
> > On August 22, 2001 09:05 pm, Marcelo Tosatti wrote:
> > > On Wed, 22 Aug 2001, Daniel Phillips wrote:
> > > > What can we do right now? We could always just comment out the alloc failed
> > > > message. The result will be a lot of busy waiting on dirty page writeout
> > > > which will work but it will keep us from focussing on the question: how did
> > > > we get so short of bounce buffers? Well, maybe we are submitting too much IO
> > > > without intelligent throttling (/me waves at Ben). That sounds like the
> > > > place to attack first.
> > >
> > > We can just wait on the writeout of lowmem buffers at page_launder()
> > > (which will not cause IO buffering since we are doing lowmem IO, duh), and
> > > then we are done.
> > >
> > > Take a look at the patch I posted before (__GFP_NOBOUNCE).
> >
> > A little light reading for a Wednesday afternoon ;-)
> >
> > Nice hack, way to go. So this will wait synchronously in try_to_free_buffers
> > if we have to go around twice in alloc_bounce_page or alloc_bounce_bh (the
> > latter eventually resulting in a page_alloc from kmem_cache grow).
>
> Not synchronously, no. It will just allow allocations trying to get memory
> for bounce buffering to block on lowmem IO.
Whoops, it's been a while since I read page_launder. Hey! Major cleanup.
It's much easier to understand what it's doing now.
OK, sync_page_buffers no longer does what its name says, or implements what
its comment says it does. Now the GFP_WAIT just means wait on already-locked
buffers so that IO can be initiated. (By the way, there are bunch of
comments in try_to_free_buffers that lie now.) OK, so the busy wait is
implemented in alloc_bounce_page, and page_launder is just used to start IO,
fine. Hmm, I think I will try my semaphore idea, not because you haven't
solved the problem, but because I think a lot of CPU-wasting trips into
page_launder could be eliminated. (A 2.5 thing of course.)
> With this behaviour, its safe to completly remove Ingo's emergency scheme.
Yes, so why don't you add that to your patch, and also the correction to the
page->zone test and call it [PATCH]?
> > What does SLAB_LEVEL_MASK do? Did you find out by hitting the BUG when you
> > tried the patch? Anyway, it needs a comment.
>
> SLAB_LEVEL_MASK is the mask for SLAB-valid allocations.
And "LEVEL" means?
--
Daniel
next prev parent reply other threads:[~2001-08-23 2:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-22 4:47 Tommy Wu
2001-08-22 19:32 ` Daniel Phillips
2001-08-22 19:05 ` Marcelo Tosatti
2001-08-23 1:11 ` Daniel Phillips
2001-08-23 0:10 ` Marcelo Tosatti
2001-08-23 2:29 ` Daniel Phillips [this message]
2001-08-23 1:19 ` Marcelo Tosatti
[not found] <20010821174918Z16114-32383+718@humbolt.nl.linux.org>
2001-08-21 13:46 ` Stephan von Krawczynski
2001-08-21 14:33 ` Daniel Phillips
[not found] ` <20010821194140.43b46b10.skraw@ithnet.com>
2001-08-21 18:17 ` Stephan von Krawczynski
2001-08-21 19:10 ` Daniel Phillips
2001-08-22 0:04 ` Stephan von Krawczynski
2001-08-22 0:43 ` Daniel Phillips
2001-08-22 0:48 ` Rik van Riel
2001-08-22 1:13 ` Daniel Phillips
2001-08-22 11:01 ` Stephan von Krawczynski
2001-08-22 17:22 ` Mike Galbraith
2001-08-22 19:18 ` Stephan von Krawczynski
2001-08-23 4:57 ` Mike Galbraith
2001-08-22 10:43 ` Stephan von Krawczynski
2001-08-22 11:52 ` Stephan von Krawczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010823022243Z16060-32383+932@humbolt.nl.linux.org \
--to=phillips@bonn-fries.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=tommy@teatime.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®