mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Paul <set@pobox.com>, Andi Kleen <ak@suse.de>,
	Brian Gerst <bgerst@didntduck.org>,
	linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
	Wilfried.Weissmann@gmx.at
Subject: Re: [OOPS] repeatable 2.4.8-ac7, 2.4.7-ac6 just run xdos
Date: Thu, 23 Aug 2001 15:34:19 +0200	[thread overview]
Message-ID: <20010823153419.A8743@gruyere.muc.suse.de> (raw)
In-Reply-To: <20010819004703.A226@squish.home.loc.suse.lists.linux.kernel> <3B831CDF.4CC930A7@didntduck.org.suse.lists.linux.kernel> <oupn14sny4f.fsf@pigdrop.muc.suse.de> <3B839E47.874F8F64@didntduck.org> <20010822141058.A18043@gruyere.muc.suse.de> <3B83A17C.CB8ABC53@didntduck.org> <20010822152203.A18873@gruyere.muc.suse.de> <20010822155226.A228@squish.home.loc>
In-Reply-To: <20010822155226.A228@squish.home.loc>; from set@pobox.com on Wed, Aug 22, 2001 at 03:52:26PM -0400

On Wed, Aug 22, 2001 at 03:52:26PM -0400, Paul wrote:
> Andi Kleen <ak@suse.de>, on Wed Aug 22, 2001 [03:22:03 PM] said:
> > 
> > Here is a new patch with both checks.
> > 
> 
> 	Dear Andi;
> 
> 	Well, with this patch, the kernel doesnt oops, but vm86
> seems to be busted now. save_v86_state() pops out:
> 	'vm86: could not access userspace vm86_info'
> and gives dosemu a segv.

I found the problem in the previous patch. Here is an updated one.
Please test again. Again against -ac7 (or later if Alan hasn't applied 
the earlier patch) 


-Andi




--- include/asm-i386/hw_irq.h-SEG2	Mon Aug 20 02:54:53 2001
+++ include/asm-i386/hw_irq.h	Wed Aug 22 13:02:16 2001
@@ -114,8 +114,10 @@
 	"cmpl %eax,7*4(%esp)\n\t"  \
 	"je 1f\n\t"  \
 	"movl %eax,%ds\n\t" \
+	"1: cmpl %eax,8*4(%esp)\n\t" \
+	"je 2f\n\t" \
 	"movl %eax,%es\n\t" \
-	"1:\n\t"
+	"2:\n\t"
 
 #define IRQ_NAME2(nr) nr##_interrupt(void)
 #define IRQ_NAME(nr) IRQ_NAME2(IRQ##nr)
--- arch/i386/kernel/entry.S-SEG2	Sat Aug 18 08:41:53 2001
+++ arch/i386/kernel/entry.S	Thu Aug 23 15:20:21 2001
@@ -291,9 +291,11 @@
 	movl $(__KERNEL_DS),%edx
 	cmpl %edx,%ecx
 	jz	1f
-	movl %edx,%ds
 	movl %edx,%es
-1:	GET_CURRENT(%ebx)
+1:	cmpl %edx,9*4(%esp)	# check ds on the stack
+	jz   2f	
+	movl %edx,%ds
+2:	GET_CURRENT(%ebx)
 	call *%edi
 	addl $8,%esp
 	jmp ret_from_exception

  reply	other threads:[~2001-08-23 13:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20010819004703.A226@squish.home.loc.suse.lists.linux.kernel>
     [not found] ` <3B831CDF.4CC930A7@didntduck.org.suse.lists.linux.kernel>
2001-08-22 11:16   ` Andi Kleen
2001-08-22 11:57     ` Brian Gerst
2001-08-22 12:10       ` Andi Kleen
2001-08-22 12:11         ` Brian Gerst
2001-08-22 13:22           ` Andi Kleen
2001-08-22 19:52             ` Paul
2001-08-23 13:34               ` Andi Kleen [this message]
2001-08-23 18:05                 ` Paul
2001-08-23 18:20                 ` Wayne Whitney
2001-08-19  4:47 Paul
2001-08-19  5:09 ` Jeff Chua
2001-08-19  5:40   ` Paul
2001-08-19  8:04     ` Jeff Chua
2001-08-19 20:30       ` Eric W. Biederman
2001-08-19  5:10 ` Jeff Chua
2001-08-22  2:45 ` Brian Gerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010823153419.A8743@gruyere.muc.suse.de \
    --to=ak@suse.de \
    --cc=Wilfried.Weissmann@gmx.at \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bgerst@didntduck.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=set@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®