Re: scr_*() audit

[Helge Deller <deller@gmx.de>]

On Monday 27 August 2001 00:30, Hollis Blanchard wrote:
> On Wed, Aug 22, 2001 at 07:06:12PM +0200, Geert Uytterhoeven wrote:
> > Since there are still some issues left with the scr_*() functions on
> > big-endian platforms that can have both VGA and frame buffer consoles, I
> > decided to spent some precious time on auditing the usage of these
> > functions.
>
> Much appreciated.
>
> For the record, this resolves my problems with VGA console (only; no fb) on
> PPC. Previously text written to non-active consoles was endian-reversed.
>
> If no one has any problems (anyone else tested it?), could this patch
> please be committed?

For me it looks good too. I just tested it on HP parisc in text- and fb-mode and 
it worked without any problems. I only had to add a missing semicolon to the
patch:
linux-2.4.8-ac9/drivers/char/console.c:
                        while (cnt--) {
-                               u16 a = *q;
+                               a = scr_readw(q);
                                a = ((a) & 0x88ff) | (((a) & 0x7000) >> 4) | (((a) & 0x0700) << 4);
-                               *q++ = a;
+                               scr_writew(a, q);
+                               q++
                                     ^^^ here

Greetings,
Helge