From: Richard Gooch <rgooch@ras.ucalgary.ca>
To: <pmhahn@titan.lahn.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuid/msr + devfs
Date: Mon, 3 Sep 2001 14:07:03 -0600 [thread overview]
Message-ID: <200109032007.f83K73H27504@vindaloo.ras.ucalgary.ca> (raw)
In-Reply-To: <Pine.LNX.4.33.0108121020050.1068-100000@titan.lahn.de>
In-Reply-To: <Pine.LNX.4.33.0108121020050.1068-100000@titan.lahn.de>
Philipp Matthias Hahn writes:
> Hello Richard, LKML!
>
> Back in 2000 Philip Langdale posted a patch to make
> arch/i386/kernel/{cpuid,msr}.c devfs aware. Richard Gooch had some
> comments for him but I never saw an "improved" patch.
>
> I tried to clean it up a little bit and it look's better, but here are the
> things I don't like myself:
> - Do we need to keep cpu_devfs_handle or should we re-find it on
> unregister?
Better to have a central place which creates per-CPU directories,
which you can call into and grab a directory for a CPU.
> - There is no devfs_unregister_series.
Correct. I'm not sure that we really want one, either.
> - Shouldn't we register_chrdev() "cpu/%d/cpuid"?
You could if you want.
> - "cpu/%d" directoried are never removed on unregister.
Such directories should only be removed when a CPU is removed. And to
support that, you need the CPU hotplug patch.
Regards,
Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca
next prev parent reply other threads:[~2001-09-03 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-12 8:33 Philipp Matthias Hahn
2001-09-03 20:07 ` Richard Gooch [this message]
2001-09-03 20:34 ` Zach Brown
2001-09-03 20:51 ` Richard Gooch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200109032007.f83K73H27504@vindaloo.ras.ucalgary.ca \
--to=rgooch@ras.ucalgary.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=pmhahn@titan.lahn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®