mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Steve Kieu" <haiquy@yahoo.com>
To: Stephen Tweedie <sct@redhat.com>
Cc: kernel <linux-kernel@vger.kernel.org>
Subject: Re: ext3 oops under moderate load
Date: Tue, 4 Sep 2001 09:10:27 +1000 (EST)	[thread overview]
Message-ID: <20010903231027.51629.qmail@web10407.mail.yahoo.com> (raw)
In-Reply-To: <20010903172323.A20255@devserv.devel.redhat.com>

 --- Stephen Tweedie <sct@redhat.com> wrote: > Hi,
> 
> On Fri, Aug 31, 2001 at 07:41:08PM -0700, Andrew
> Morton wrote:
> 
> > > kernel BUG at revoke.c:307!
> > 
> > Yours is the third report of this - it's
> definitely a bug in
> > ext3.  I still need to work out how you managed to
> get a page
> > attached to the inode which has not had its
> buffers fed through
> > journal_dirty_data().  There seem to be several
> ways in which
> > this can happen.
> 
> I've just been able to reproduce it, using large
> symlinks.
> 
> The killer seems to be a situation when you have a
> revoked
> buffer-cache buffer and we then start allocating,

Just want to add another situation. The previous post
about the system hang-up I suspected DRI module
related but it is not. It wont happen when I mount my
/dev/hda6 as ext2 (not ext3). The hang up happen when
I untar a tgz file (about 20Mb) to a loop device, loop
device attached to a 100Mb file in the ext3 partition.
And at the same time I untar the linux kenel from ext2
partition to ext3 partition. And I am playing Timidity
, running Mozilla. It is not swap related problem.

Hope that you may find it useful for your fix :-)

Cheers,

> and deallocating,
> the same buffer from the page cache.  Large symlinks
> work from the
> page cache and satisfy this condition nicely.
> 
> Running a few parallel tasks writing to the end of
> large sparse files
> and truncating them (to create and delete lots of
> indirect blocks,
> populating the buffer cache with revoked data), then
> adding large
> symlink create/delete activity in the same
> directory, I was able to
> reproduce the oops in a few minutes.
> 
> I suspect that the same sort of effect is causing
> the revoke oops
> Peter Braam saw with discretionally journaled files.
> 
> How to fix?  Well, the issue is that whenever we
> create any journaled
> data, we need to cancel all previous indications of
> the revoke, even
> if the old revoke was in the buffer cache but the
> new block is in the
> page cache.  That implies we effectively need the
> same as
> unmap_underlying_metadata, but for our own specific
> piece of metadata.
> Indeed, unmap_underlying_metadata already does the
> required lookup of
> the old cached buffer_head.  If we can pass in the
> page and the
> looked-up alias to an address_space a_ops, then:
> 
> 1) we can piggy-back the revoke cleanup on top of
> the existing
> get_hash_table which unmap_underlying_metadata
> performs; and
> 
> 2) we can detect whether the calling inode is
> journaled, so we know
> whether or not to clear out the revoke status on the
> underlying
> buffer_head (after all, if we're only allocating the
> new page as
> unjournaled data, the old revoke status should stay
> intact.)
> 
> It's now 10pm and the baby is crying, so I guess
> that testing the fix
> can wait until tomorrow. :)
> 
> Cheers,
>  Stephen
> 
> -
> To unsubscribe from this list: send the line
> "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at 
> http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/ 

=====
S.KIEU

http://travel.yahoo.com.au - Yahoo! Travel
- Got Itchy feet? Get inspired!

      reply	other threads:[~2001-09-03 23:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.33.0108301740420.7921-100000@inconnu.isu.edu>
2001-08-31  7:19 ` mb/ext3
2001-08-31 10:33   ` mb/ext3
2001-09-01  2:41   ` Andrew Morton
2001-09-01  6:29     ` mb/ext3
2001-09-03 21:14     ` Stephen C. Tweedie
2001-09-03 21:23     ` Stephen Tweedie
2001-09-03 23:10       ` Steve Kieu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010903231027.51629.qmail@web10407.mail.yahoo.com \
    --to=haiquy@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®