mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: ak@suse.de, jeffm@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [SOLVED + PATCH]: documented Oops running big-endian reiserfs on parisc architecture
Date: Tue, 4 Sep 2001 12:25:24 +0200	[thread overview]
Message-ID: <20010904122524.A26403@gruyere.muc.suse.de> (raw)
In-Reply-To: <20010903003437.A385@linux-m68k.org.suse.lists.linux.kernel> <20010903213835.A13887@fury.csh.rit.edu.suse.lists.linux.kernel> <oupoforxpc1.fsf@pigdrop.muc.suse.de> <20010904.030454.85412225.davem@redhat.com>
In-Reply-To: <20010904.030454.85412225.davem@redhat.com>; from davem@redhat.com on Tue, Sep 04, 2001 at 03:04:54AM -0700

On Tue, Sep 04, 2001 at 03:04:54AM -0700, David S. Miller wrote:
>    From: Andi Kleen <ak@suse.de>
>    Date: 04 Sep 2001 11:44:30 +0200
> 
>    Jeff Mahoney <jeffm@suse.com> writes:
>    
>    >     I did kick around the idea of making those macros the default accessors for
>    >     the deh_state member (which is the only place they're used), but it unfairly
>    >     penalizes arches that don't need them.
>    
>    On archs that don't need them {get,put}_unaligned should be just normal
>    assignments. They are certainly on i386.
> 
> I can also almost guarentee you that the x86 will sometimes not
> execute these bitops atomically on SMP.

It's not needed when you have another lock to protect and don't have
interrupt threads.

iirc near all of reiserfs still runs under the BKL. BKL/schedule are full
memory barriers.

> What's more, you will have less QA'ing to do, since this code will
> always be in use and thus tested.

I think for a fs it is best to go with bigger locks and avoid the issue
of atomic operations completely.

-Andi

  reply	other threads:[~2001-09-04 10:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20010902105538.A15344@middle.of.nowhere.suse.lists.linux.kernel>
     [not found] ` <20010902150023.U5126@parcelfarce.linux.theplanet.co.uk.suse.lists.linux.kernel>
     [not found]   ` <20010902195717.A21209@middle.of.nowhere.suse.lists.linux.kernel>
     [not found]     ` <20010903003437.A385@linux-m68k.org.suse.lists.linux.kernel>
     [not found]       ` <20010903213835.A13887@fury.csh.rit.edu.suse.lists.linux.kernel>
2001-09-04  9:44         ` Andi Kleen
2001-09-04 12:50           ` Jeff Mahoney
2001-09-04 10:04         ` David S. Miller
2001-09-04 10:25           ` Andi Kleen [this message]
2001-09-04 10:29           ` David S. Miller
2001-09-04 10:52           ` [SOLVED + PATCH]: documented Oops running big-endian reiserfs Alan Cox
2001-09-04 22:55 [SOLVED + PATCH]: documented Oops running big-endian reiserfs on parisc architecture Ulrich Weigand
  -- strict thread matches above, loose matches on Subject: below --
2001-09-04 17:04 Ulrich Weigand
2001-09-04 14:34 Ulrich Weigand
2001-09-04 15:02 ` Richard B. Johnson
2001-09-04 16:09 ` John Alvord
2001-09-03 12:08 Ulrich Weigand
2001-09-03 13:14 ` Ralf Baechle
2001-09-03 22:24 ` David S. Miller
2001-09-08  1:41   ` Linus Torvalds
2001-09-02  8:55 thunder7
2001-09-02 14:00 ` [parisc-linux] " Matthew Wilcox
2001-09-02 17:57   ` [SOLVED + PATCH]: " thunder7
2001-09-02 22:34     ` Richard Zidlicky
2001-09-04  1:38       ` Jeff Mahoney
2001-09-02 23:08     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010904122524.A26403@gruyere.muc.suse.de \
    --to=ak@suse.de \
    --cc=davem@redhat.com \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®