mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Perry <mikepery@fscked.org>
To: linux-kernel@vger.kernel.org
Subject: [PATCH]: PCnet/HOME media type
Date: Mon, 17 Sep 2001 02:24:24 -0500	[thread overview]
Message-ID: <20010917022424.A4282@fscked.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

I recently had the misfortune of having to use a one of those
PCnet/HOME RJ11 networking devices, and I noticed that the pcnet32
driver in 2.4.9 wasn't setting the media type for that device.
(Actually, it appeared to be moved within an #if 0, so all I really had
to do was move it back out). For some reason the default type on my
device was to use 10BaseT (0x8000), and not the HomePNA (0x8001).

Also, the tech docs for the PCnet/Home say it uses a 79c971 core, so I
was wondering if the flags for the 79c971 should be set for it as well.
Since it worked for me either way, I just left the new flags commented
in this patch.

--
Mike Perry
Minister of General Mayhem
fscked.org enterprises, inc

[-- Attachment #2: pcnet.patch --]
[-- Type: text/plain, Size: 880 bytes --]

--- linux.orig/drivers/net/pcnet32.c	Mon Sep 17 01:49:58 2001
+++ linux/drivers/net/pcnet32.c	Mon Sep 17 01:56:21 2001
@@ -570,7 +570,10 @@
 	break;
     case 0x2626:
 	chipname = "PCnet/Home 79C978"; /* PCI */
-	fdx = 1;
+	/* We are the same as the 79c971, but these flags don't make
+	 * a difference either way as far as it working, so I left them 
+	 * off */
+	fdx = 1; /* mii = 1; fset = 1; ltint = 1; */
 	/* 
 	 * This is based on specs published at www.amd.com.  This section
 	 * assumes that a card with a 79C978 wants to go into 1Mb HomePNA
@@ -583,9 +586,9 @@
 #if 0
 	if (pcnet32_debug > 2)
 	    printk(KERN_DEBUG "pcnet32: pcnet32 media value %#x.\n",  media);
-	media &= ~3;
-	media |= 1;
 #endif
+	media &= ~3;
+	media |= 1; 
 	if (pcnet32_debug > 2)
 	    printk(KERN_DEBUG "pcnet32: pcnet32 media reset to %#x.\n",  media);
 	a->write_bcr (ioaddr, 49, media);

                 reply	other threads:[~2001-09-17  7:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010917022424.A4282@fscked.org \
    --to=mikepery@fscked.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®