From: Artur Frysiak <wiget@pld.org.pl>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] modutils: ieee1394 device_id extraction
Date: Mon, 17 Sep 2001 13:15:40 +0200 [thread overview]
Message-ID: <20010917131540.B27430@ikar.t17.ds.pwr.wroc.pl> (raw)
In-Reply-To: <29177.1000629997@ocs3.intra.ocs.com.au> <m3pu8rh20i.fsf@dk20037170.bang-olufsen.dk>
In-Reply-To: <m3pu8rh20i.fsf@dk20037170.bang-olufsen.dk>
On Sun, Sep 16, 2001 at 12:18:53PM +0200, Kristian Hogsberg wrote:
> @@ -1225,6 +1306,8 @@
> if (usbmap != stdout)
> fclose(usbmap);
> if (parportmap != stdout)
> + fclose(parportmap);
> + if (ieee1394map != stdout)
> fclose(parportmap);
> /* Close depfile last, it's timestamp is critical */
> if (dep != stdout)
I think, this part is bad. You test for ieee139map file pointer and close
parportmap.
Regards
--
Artur Frysiak
http://www.pld.org.pl/
prev parent reply other threads:[~2001-09-17 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-15 16:02 Kristian Hogsberg
2001-09-15 16:12 ` Ben Collins
2001-09-15 16:28 ` Kristian Hogsberg
2001-09-15 17:40 ` Ben Collins
2001-09-16 8:46 ` Keith Owens
2001-09-16 10:18 ` Kristian Hogsberg
2001-09-17 11:15 ` Artur Frysiak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010917131540.B27430@ikar.t17.ds.pwr.wroc.pl \
--to=wiget@pld.org.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®