From: Marcus Meissner <mm@ns.caldera.de>
To: adam@yggdrasil.com ("Adam J. Richter"), linux-kernel@vger.kernel.org
Subject: Re: PATCH: linux-2.4.10-pre14/drivers/sound/maestro.c ignored pci_module_init results
Date: Sun, 23 Sep 2001 18:24:14 +0200 [thread overview]
Message-ID: <200109231624.f8NGOEX24344@ns.caldera.de> (raw)
In-Reply-To: <20010922230237.A10872@baldur.yggdrasil.com>
In article <20010922230237.A10872@baldur.yggdrasil.com> you wrote:
> --M9NhX3UHpAaciwkO
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> The initialization routine in
> linux-2.4.10-pre14/drivers/sound/maestro.c ignores the return value
> from pci_module_init, and allows module initialization to succeed
> even if pci_module_init failed. pci_module_init fails and unloads
> the driver if the caller is a module and there is no matching hardware.
> Because maestro.c ignored this failure, loading maestro.o on a system
> where the corresponding alsa driver was already loaded or on a system
> without matchin hardware would result in a kernel null pointer dereference
> in pci_unregister_driver when the module is unloaded or when one
> attempts to reboot the system (i.e., when the module attempt to
> unregister a PCI driver that is not registered).
Why and where does it Oops? The code for pci_unregister_driver in
drivers/pci/pci.c looks correct and should not Oops.
The reboot notifier might be problematic, but I have not checked it.
Ciao, Marcus
next prev parent reply other threads:[~2001-09-23 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-23 6:02 Adam J. Richter
2001-09-23 16:24 ` Marcus Meissner [this message]
2001-09-23 21:21 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200109231624.f8NGOEX24344@ns.caldera.de \
--to=mm@ns.caldera.de \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®