mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh MacDonald <jmacd@CS.Berkeley.EDU>
To: linux-kernel@vger.kernel.org
Subject: Is <linux/ghash.h> dead?
Date: Wed, 26 Sep 2001 16:05:20 -0700	[thread overview]
Message-ID: <20010926160520.C18363@helen.CS.Berkeley.EDU> (raw)

I cannot find any code in the main tree that depends on this header
file.  Furthermore, I am somewhat skeptical of the algorithms.  Maybe
the first comment has scared people away:

    "The algorithms implemented here seem to be a completely new
    invention, and I'll publish the fundamentals in a paper."

It defines two generic hash table classes using C preprocessor macros,
a "fuzzy" hash and an ordinary hash.

The "fuzzy" hash class is useless without a description.  What does
find_hash_fuzzy do?

The ordinary hash class maintains an ring-ordered doubly-linked list
of entries for each hash synonym, and it performs a move-to-front
heuristic on insertion (but not for the find operation).  

The second and final comment ("HASHSIZE _must_ be a power of two!!!")
does not apply to the ordinary hash class.

Would anyone care defend either of these hash classes?

-josh

                 reply	other threads:[~2001-09-26 23:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010926160520.C18363@helen.CS.Berkeley.EDU \
    --to=jmacd@cs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®