From: Andrea Arcangeli <andrea@suse.de>
To: Robert_Macaulay@Dell.com
Cc: riel@conectiva.com.br, ckulesa@as.arizona.edu,
linux-kernel@vger.kernel.org, bmatthews@redhat.com,
marcelo@conectiva.com.br, torvalds@transmeta.com
Subject: Re: highmem deadlock fix [was Re: VM in 2.4.10(+tweaks) vs. 2.4.9 -ac14/15(+stuff)]
Date: Fri, 28 Sep 2001 00:37:46 +0200 [thread overview]
Message-ID: <20010928003746.Q14277@athlon.random> (raw)
In-Reply-To: <8F120FA493CAD743B30EEB8F356985B501A7819D@AUSXMBT102VS1.amer.dell.com>
In-Reply-To: <8F120FA493CAD743B30EEB8F356985B501A7819D@AUSXMBT102VS1.amer.dell.com>; from Robert_Macaulay@Dell.com on Thu, Sep 27, 2001 at 05:34:17PM -0500
On Thu, Sep 27, 2001 at 05:34:17PM -0500, Robert_Macaulay@Dell.com wrote:
>
>
> > -----Original Message-----
> > From: Andrea Arcangeli [mailto:andrea@suse.de]
> > Sent: Thursday, September 27, 2001 5:13 PM
> > To: Macaulay, Robert
> > Cc: Rik van Riel; Craig Kulesa; linux-kernel@vger.kernel.org; Bob
> > Matthews; Marcelo Tosatti; Linus Torvalds
> > Subject: highmem deadlock fix [was Re: VM in 2.4.10(+tweaks) vs.
> > 2.4.9-ac14/15(+stuff)]
> >
> > @@ -2519,7 +2521,9 @@
> > int tryagain = 1;
> >
> > do {
> > - if (buffer_dirty(p) || buffer_locked(p)) {
> > + if (unlikely(buffer_pending_IO(p)))
> > + tryagain = 0;
> > + else if (buffer_dirty(p) || buffer_locked(p)) {
> > if (test_and_set_bit(BH_Wait_IO, &p->b_state)) {
> > if (buffer_dirty(p)) {
> > ll_rw_block(WRITE, 1, &p);
> >
>
> Im getting an undefined reference to the unlikely function in this patch.
ok, try adding #include <linux/compiler.h> to include/linux/kernel.h, I
prefer to have likely/unlikely always available.
Andrea
next prev parent reply other threads:[~2001-09-27 22:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-27 22:34 Robert_Macaulay
2001-09-27 22:37 ` Andrea Arcangeli [this message]
2001-09-27 22:39 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010928003746.Q14277@athlon.random \
--to=andrea@suse.de \
--cc=Robert_Macaulay@Dell.com \
--cc=bmatthews@redhat.com \
--cc=ckulesa@as.arizona.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=riel@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®