mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin Röder" <m-roeder@gmx.net>
To: linux-kernel@vger.kernel.org
Subject: ACPI processor throttling problem in 2.4.10
Date: Fri, 28 Sep 2001 15:50:01 +0200	[thread overview]
Message-ID: <20010928134942Z276053-760+18150@vger.kernel.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi,

with the 2.4.10 kernel my processor doesn't enter the C2 power state any 
more. I found the reason to be the state promotion part of pr_power_idle() 
which actually does no state promotion if bm_control is 0.
As far as I understand, the bm_control flag should only disable the C3 state 
on machines where busmastering can't be controlled and not disable state 
changing completely.
The attached patch should correct this problem.

  Martin

[-- Attachment #2: prpower.diff --]
[-- Type: text/plain, Size: 471 bytes --]

--- linux/drivers/acpi/ospm/processor/prpower.c.orig	Sun Sep 23 18:42:32 2001
+++ linux/drivers/acpi/ospm/processor/prpower.c	Fri Sep 28 13:01:45 2001
@@ -274,7 +274,7 @@
 			 * by this state's promotion policy, prevents
 			 * promotions from occuring.
 			 */
-			if (bm_control && !(processor->power.bm_activity &
+			if (!bm_control || !(processor->power.bm_activity &
 				c_state->promotion.bm_threshold)) {
 				next_state = c_state->promotion.target_state;
 			}

                 reply	other threads:[~2001-09-28 13:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010928134942Z276053-760+18150@vger.kernel.org \
    --to=m-roeder@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®