From: Stelian Pop <stelian.pop@fr.alcove.com>
To: Thomas Hood <jdthood@mail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PnP BIOS + 2.4.9-ac16 = no boot
Date: Fri, 28 Sep 2001 16:54:06 +0200 [thread overview]
Message-ID: <20010928165406.M21524@come.alcove-fr> (raw)
In-Reply-To: <3BB47F7F.DE2FD301@mail.com> <20010928160250.K21524@come.alcove-fr> <3BB48C29.356901F1@mail.com>
In-Reply-To: <3BB48C29.356901F1@mail.com>
On Fri, Sep 28, 2001 at 10:41:45AM -0400, Thomas Hood wrote:
> Stelian Pop wrote:
> > What about making a conditional on 'is_sony_vaio_laptop' here ?
> > (but you need to extends the conditionnal export of this variable
> > from dmi_scan.c / i386_ksyms.c).
>
> In addition to applying the patch I just sent
> (thood-pnpbiosvaio-patch-20010928-3), you will have
> to move the definition of is_sony_vaio_laptop outside
> the #ifdefs in arch/i386/kernel/dmi_scan.c and i386_ksyms.c
No need for me since I have CONFIG_SONYPI on.
> You or Alan: For the cleaned up patch, do we export this
> variable unconditionally?
I'd vote for unconditionnally define one int instead of having
something like:
#if defined(CONFIG_SONYPI) || defined(CONFIG_SONYPI_MODULE) || ( defined(CONFIG_PNP) && defined(CONFIG_PROC) )
(and maybe other defines in the future... :( ).
Stelian.
--
Stelian Pop <stelian.pop@fr.alcove.com>
|---------------- Free Software Engineer -----------------|
| Alcôve - http://www.alcove.com - Tel: +33 1 49 22 68 00 |
|------------- Alcôve, liberating software ---------------|
next prev parent reply other threads:[~2001-09-28 14:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-28 13:47 Thomas Hood
2001-09-28 14:02 ` Stelian Pop
2001-09-28 14:41 ` Thomas Hood
2001-09-28 14:54 ` Stelian Pop [this message]
2001-09-28 14:58 ` Alan Cox
2001-09-28 14:58 ` Thomas Hood
2001-10-02 22:11 ` Ion Badulescu
2001-10-03 9:28 ` Stelian Pop
-- strict thread matches above, loose matches on Subject: below --
2001-10-02 23:29 Thomas Hood
2001-10-03 14:06 ` Ion Badulescu
2001-10-02 23:17 Thomas Hood
2001-09-28 14:33 Thomas Hood
2001-09-28 14:51 ` Stelian Pop
2001-09-28 15:20 ` Thomas Hood
2001-09-28 15:28 ` Alan Cox
[not found] <3BB46DCD.91576F70@mail.com>
2001-09-28 13:12 ` Stelian Pop
2001-09-28 12:29 Thomas Hood
2001-09-28 10:46 Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010928165406.M21524@come.alcove-fr \
--to=stelian.pop@fr.alcove.com \
--cc=jdthood@mail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®