From: Greg KH <greg@kroah.com>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: linux-kernel@vger.kernel.org
Subject: Re: USB SMP race in 2.4.11
Date: Wed, 10 Oct 2001 11:31:45 -0700 [thread overview]
Message-ID: <20011010113145.E7782@kroah.com> (raw)
In-Reply-To: <20011010222223.A1223@linuxhacker.ru>
In-Reply-To: <20011010222223.A1223@linuxhacker.ru>
On Wed, Oct 10, 2001 at 10:22:23PM +0400, Oleg Drokin wrote:
> Hello!
>
> I have caught kernel oops that is related to SMP race on usb modules
> deregistering.
> 2.4.10 was fine with the same setup.
> USB core is compiled-in, hub driver is uhci (as module).
> Here is the decoded oops:
Can you try the attached patch and let us know if the oops still
happens?
thanks,
greg k-h
diff --minimal -Nru a/drivers/usb/uhci.c b/drivers/usb/uhci.c
--- a/drivers/usb/uhci.c Wed Oct 10 07:32:38 2001
+++ b/drivers/usb/uhci.c Wed Oct 10 07:32:38 2001
@@ -1594,9 +1594,7 @@
}
uhci_unlink_generic(uhci, urb);
- uhci_destroy_urb_priv(urb);
-
- usb_dec_dev_use(urb->dev);
+ uhci_call_completion(urb);
return ret;
}
next prev parent reply other threads:[~2001-10-10 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-10 18:22 Oleg Drokin
2001-10-10 18:31 ` Greg KH [this message]
2001-10-10 18:34 ` Johannes Erdfelt
2001-10-10 18:37 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011010113145.E7782@kroah.com \
--to=greg@kroah.com \
--cc=green@linuxhacker.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®