From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Unconditional include of <linux/module.h> in aic7xxx driver
Date: Thu, 11 Oct 2001 14:00:57 -0600 [thread overview]
Message-ID: <200110112001.f9BK0vY99173@aslan.scsiguy.com> (raw)
In-Reply-To: Your message of "Thu, 11 Oct 2001 20:52:38 BST." <E15rlsk-0004Vf-00@the-village.bc.nu>
>> unconditional in the aic7xxx driver? Assuming MODULE_LICENSE is
>> properly qualified by an #ifdef MODULE, the driver appears to compile
>> and function correctly without this include. Are MODULE attributes
>> (MODULE_VERSION/AUTHOR/DESCRIPTION/etc.) now supposed to be included in
>> static configurations?
>
>It's always been meant to work always included. For non modules it defines
>the right do nothing handlers to avoid you having to get ifdefs into the
>kernel code
So, in theory I could nuke many of the remaining "#ifdef MODULE"'s?
This wasn't done in the aic7xxx driver for 2.4.12. My only concern with
doing this is having the driver still work on older kernel versions.
--
Justin
next prev parent reply other threads:[~2001-10-11 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-11 19:40 Justin T. Gibbs
2001-10-11 19:52 ` Alan Cox
2001-10-11 20:00 ` Justin T. Gibbs [this message]
2001-10-11 20:15 ` Jeff Garzik
2001-10-11 19:57 ` Jeff Garzik
2001-10-11 23:56 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200110112001.f9BK0vY99173@aslan.scsiguy.com \
--to=gibbs@scsiguy.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®