From: Richard Gooch <rgooch@ras.ucalgary.ca>
To: Martin Wilck <Martin.Wilck@fujitsu-siemens.com>
Cc: Matt Domsch <mdomsch@Dell.com>,
Linux Kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EFI GUID Partition Tables
Date: Fri, 12 Oct 2001 08:56:05 -0600 [thread overview]
Message-ID: <200110121456.f9CEu5j15440@vindaloo.ras.ucalgary.ca> (raw)
In-Reply-To: <Pine.LNX.4.33.0110121026430.9327-100000@biker.pdb.fsc.net>
In-Reply-To: <200110091725.f99HPZ530405@vindaloo.ras.ucalgary.ca> <Pine.LNX.4.33.0110121026430.9327-100000@biker.pdb.fsc.net>
Martin Wilck writes:
> Richard,
>
> > You've put the devfs_unregister_slave() inside an #ifdef. Yuk! It
> > shouldn't be conditional.
>
> I did that because I didn't want to pollute your code. The function
> was only needed for the UUID patch.
>
> > And I'm not really sure that I like this
> > function in the first place, but that's not something I want to get
> > into right now.
>
> I did not see a possibility to cleanly remove a slave that was
> registered before. Did I oversee something? Do you thing that
> functionality is superfluous?
The whole slave mechanism is a hack, created because of the badly
structured genhd layer. It's a convenience for lazy programmers (like
me, when I was hacking the genhd layer:-). I'd prefer to see it used
very sparingly.
Regards,
Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca
next prev parent reply other threads:[~2001-10-12 14:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-09 17:15 Matt Domsch
2001-10-09 17:25 ` Richard Gooch
2001-10-12 8:31 ` Martin Wilck
2001-10-12 16:27 ` Andreas Dilger
2001-10-12 14:56 ` Richard Gooch [this message]
2001-10-09 21:03 ` Andreas Dilger
2001-10-10 3:01 Matt_Domsch
2001-10-10 4:23 ` Andreas Dilger
2001-10-12 10:12 ` Martin Wilck
2001-10-10 5:18 ` Richard Gooch
2001-10-10 22:08 Matt_Domsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200110121456.f9CEu5j15440@vindaloo.ras.ucalgary.ca \
--to=rgooch@ras.ucalgary.ca \
--cc=Martin.Wilck@fujitsu-siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mdomsch@Dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®