Re: [Bench] New benchmark showing fileserver problem in 2.4.12

[Roger Larsson <roger.larsson@skelleftea.mail.telia.com>]

On Friday 19 October 2001 04:53, you wrote:
> On Thu, 18 Oct 2001, Roger Larsson wrote:
> >On Thursday 18 October 2001 04:01, Leo Mauro wrote:
> >> Small fix to Linus's sample code
> >>
> >>  	unsigned int so_far = 0;
> >>  	for (;;) {
> >>  		int bytes = read(in, buf+so_far, BUFSIZE-so_far);
> >>  		if (bytes <= 0)
> >>  			break;
> >>  		so_far += bytes;
> >>  		if (so_far < BUFSIZE)
> >>  			continue;
> >>  		write(out, buf, BUFSIZE);
> >> - 		so_far = 0;
> >> +		so_far -= BUFSIZE;
> >>  	}
> >>  	if (so_far)
> >>  		write(out, buf, so_far);
> >>
> >> to avoid losing data.
> >
> >I was close to press the send button but noticed the "BUFSIZE-so_far"
> >in the read call, just in time(TM).
> >
> >If it had not been there you would have needed to copy data from the
> >end of buf (from above BUFSIZE) to the beginning of buf too...
> >(the required size of buf would have been 2*BUFSIZE)
>
> Since you only ever have BUFSIZE bytes when you write, aren't:
>
>   so_far -= BUFSIZE;
>
> and
>
>   so_far = 0;
>
> identical? I'd say the assignment to 0 would be faster.

I was not specific enough. I intended to say that Linus code was ok.
And that if so_far -= BUFSIZE ever was something different from
zero you would need to move the read bytes too...

This code not using continue is probably easier to read...
(+ error checking...)

  	unsigned int so_far = 0;
  	for (;;) {
  		int bytes = read(in, buf+so_far, BUFSIZE-so_far);
  		if (bytes <= 0)
  			break;
  		so_far += bytes;
 		if (so_far == BUFSIZE) {
	  		write(out, buf, BUFSIZE);
 			so_far = 0;
		}
  	}
  	if (so_far)
  		write(out, buf, so_far);


/RogerL

-- 
Roger Larsson
Skellefteå
Sweden