From: flar@pants.nu (Brad Boyer)
To: trini@kernel.crashing.org (Tom Rini)
Cc: alan@lxorguk.ukuu.org.uk (Alan Cox),
hollis-lists@austin.rr.com (Hollis Blanchard),
pochini@denise.shiny.it (Giuliano Pochini),
linux-kernel@vger.kernel.org, linuxppc-dev@lists.linuxppc.org
Subject: Re: hfs cdrom broken in 2.4.13pre
Date: Mon, 22 Oct 2001 19:11:39 -0700 (PDT) [thread overview]
Message-ID: <20011023021139.C66662B54A@marcus.pants.nu> (raw)
In-Reply-To: <20011022155617.B6673@cpe-24-221-152-185.az.sprintbbd.net> from "Tom Rini" at Oct 22, 2001 03:56:17 PM
Tom Rini wrote:
> No, really. What's changed to break HFS cdrom support?
Based on the messages and glancing over the hfs code, I would guess
that the CD-ROM block device driver used to fake accessing the drive
at any random block size. The hfs code depends on being able to use
a particular block size (512) and if the driver for the block device
doesn't support it, stuff breaks.
(super.c lines 394-416/491 byte 10778/12361 87%)
/* set the device driver to 512-byte blocks */
set_blocksize(dev, HFS_SECTOR_SIZE);
To be more flexible, the hfs code shouldn't force a hard coded block size.
Brad Boyer
flar@allandria.com
prev parent reply other threads:[~2001-10-23 2:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-20 22:03 Giuliano Pochini
2001-10-22 21:44 ` Alan Cox
2001-10-22 22:34 ` Hollis Blanchard
2001-10-22 22:51 ` Alan Cox
2001-10-22 22:56 ` Tom Rini
2001-10-23 2:11 ` Brad Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011023021139.C66662B54A@marcus.pants.nu \
--to=flar@pants.nu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hollis-lists@austin.rr.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=pochini@denise.shiny.it \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®