mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bruce Harada <bruce@ask.ne.jp>
To: linux-kernel@vger.kernel.org
Subject: 2.2.0-preXX compile errors solved
Date: Tue, 30 Oct 2001 00:39:09 +0900	[thread overview]
Message-ID: <20011030003909.5f60fbd9.bruce@ask.ne.jp> (raw)


I was getting compile errors for 2.2.20-pre11 on a Slackware 3.6 box. Since the
errors involved undefined symbols and unmatched struct definitions, I made the
silly assumption that I was missing a header file somewhere.

After looking at it a bit more carefully and repatching, I finally noticed that
patch was failing partway through... :(

The problem goes back to 2.2.20-pre4, where the following appears in the section
of the patch relating to arch/ppc/kernel/openpic.c:

-#endif /* CONFIG_PMAC_PBOOK */
\ No newline at end of file    
+#endif /* CONFIG_PMAC_PBOOK */

It would appear that later versions of diff output the "\ No newline..." line
when they find a file that has, surprise surprise, no newline at the end.
What I failed to realise was that older versions of patch (in my case, 2.1b)
choke on this kind of thing with a malformed patch error. I tried a later
version (2.5), which copes with it quite happily.

While I realise that the answer will most likely be "Upgrade your userland!", it
might be a good idea to consider filtering these lines out for the 2.2 series,
since it's more likely to be run on older boxes.

Bruce

                 reply	other threads:[~2001-10-29 15:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011030003909.5f60fbd9.bruce@ask.ne.jp \
    --to=bruce@ask.ne.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®