From: Guus Sliepen <guus@warande3094.warande.uu.nl>
To: linux-kernel@vger.kernel.org
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"David S. Miller" <davem@redhat.com>
Subject: [PATCH] Fix check if device is ethernet in alloc_divert_blk
Date: Tue, 30 Oct 2001 16:22:35 +0100 [thread overview]
Message-ID: <20011030162235.B5566@sliepen.warande.net> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 583 bytes --]
Hello,
I was wondering why various devices like 802.11 bridges and tap devices
weren't recognized by the kernel as ethernet devices, because I got
messages like this in my syslog:
Oct 30 15:35:52 haplo kernel: divert: not allocating divert_blk for non-ethernet device bla
Instead of checking for the actual device type, alloc_divert_blk was
just checking if the string "eth" occured in the name of the interface.
Attached patch makes it do the right thing instead (I hope).
--
Met vriendelijke groet / with kind regards,
Guus Sliepen <guus@sliepen.warande.net>
[-- Attachment #1.2: patch_dv --]
[-- Type: text/plain, Size: 369 bytes --]
--- linux-2.4.13.orig/net/core/dv.c Tue Oct 30 16:09:20 2001
+++ linux-2.4.13/net/core/dv.c Tue Oct 30 16:09:26 2001
@@ -53,7 +53,7 @@
{
int alloc_size = (sizeof(struct divert_blk) + 3) & ~3;
- if (!strncmp(dev->name, "eth", 3)) {
+ if (dev->type == ARPHRD_ETHER) {
printk(KERN_DEBUG "divert: allocating divert_blk for %s\n",
dev->name);
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
next reply other threads:[~2001-10-30 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-30 15:22 Guus Sliepen [this message]
2001-10-30 20:44 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011030162235.B5566@sliepen.warande.net \
--to=guus@warande3094.warande.uu.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®