From: Stepan Koltsov <yozh@island.mx1.ru>
To: linux-kernel@vger.kernel.org
Subject: small bug? in drivers/video/vgacon.c
Date: Thu, 1 Nov 2001 12:38:59 +0300 [thread overview]
Message-ID: <20011101123750.A21051@island.mx1.ru> (raw)
Hi.
Function drivers/video/vgacon.c:vgacon_scrolldelta() doesn't work
when get 1 or -1 as 2nd arg (it doesn't scroll).
This bug can be seen rarely, cos usually this func never called with 1 or -1.
I don't quite understand, how this func works :-) but vgacon_scrolldelta
works properly with this small patch.
diff -ur linux-2.4.12-orig/drivers/video/vgacon.c linux-2.4.12/drivers/video/vgacon.c
--- linux-2.4.12-orig/drivers/video/vgacon.c Fri Sep 14 03:04:43 2001
+++ linux-2.4.12/drivers/video/vgacon.c Sat Oct 20 19:29:20 2001
@@ -931,7 +931,7 @@
c->vc_visible_origin = c->vc_origin;
else {
int vram_size = vga_vram_end - vga_vram_base;
- int margin = c->vc_size_row * 4;
+ int margin = c->vc_size_row;
int ul, we, p, st;
if (vga_rolled_over > (c->vc_scr_end - vga_vram_base) + margin) {
--
mailto:yozh@mx1.ru
ICQ:26521795
reply other threads:[~2001-11-01 9:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011101123750.A21051@island.mx1.ru \
--to=yozh@island.mx1.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=yozh@mx1.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®