Re: [PATCH] SMM BIOS on Dell i8100

[Stephane Jourdois <stephane@tuxfinder.org>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 1846 bytes --]

On Tue, Nov 06, 2001 at 05:45:13PM +0100, Massimo Dal Zotto wrote:
> I have released version 1.2 of the driver. It contains Stephane's patches
> for the I8100, a new i8kmon and some documentation. You can download from:
>     http://www.debian.org/~dz/i8k/

Hello,

Here is my patch to i8kutils-1.2 :

======
diff -u i8kutils-1.2.orig/i8kbuttons.c i8kutils-1.2/i8kbuttons.c
--- i8kutils-1.2.orig/i8kbuttons.c      Tue Nov  6 20:07:27 2001
+++ i8kutils-1.2/i8kbuttons.c   Tue Nov  6 20:11:19 2001
@@ -53,15 +53,7 @@

     DPRINTF("exec_cmd: %s\n", cmd);

-    if ((rc=fork()) < 0) {
-       perror("fork failed");
-       return;
-    }
-
-    if (rc == 0) {
-       execl("/bin/sh", "sh", "-c", cmd, NULL);
-       exit(0);
-    }
+    system(cmd);
 }
 
 static int
======

Without that, I get as much zombies processes as I have pressed the
volume buttons :-) I know system() is not great, but as security is not
a problem here...
I use debian/sid, and aumix as the mixer.


Now a fundamental question :
Does the load of the i8k module inhibits the fans start ? I can see my
processor temp increasing (I saw 80°C ...) without the fans start. Then
I started i8kmon to avoid an explosion. If the modules inhibits material
protections, then if that can be modified, it would be great ; if not,
i8kmon needs to get included in the kernel as a daemon. The i8kmon
should be a funny tool, not a system critical tool.

Also, I couldn't understand why sometimes the left fan is printed on red
color in i8kmon...


Thank you,

	Stephane


-- 
 ///  Stephane Jourdois        	/"\  ASCII RIBBON CAMPAIGN \\\
(((    Ingénieur développement 	\ /    AGAINST HTML MAIL    )))
 \\\   6, av. de la Belle Image	 X                         ///
  \\\  94440 Marolles en Brie  	/ \    +33 6 8643 3085    ///

[-- Attachment #2: Type: application/pgp-signature, Size: 240 bytes --]