From: Pete Zaitcev <zaitcev@redhat.com>
To: Cotte@de.ibm.com
Cc: linux-kernel@vger.kernel.org, Linux390@de.ibm.com
Subject: if (a & X || b & ~Y) in dasd.c
Date: Thu, 8 Nov 2001 15:57:49 -0500 [thread overview]
Message-ID: <20011108155749.A24023@devserv.devel.redhat.com> (raw)
Carsten and others:
this code in 2.2.14 looks suspicious to me:
./drivers/s390/block/dasd.c:
/* first of all lets try to find out the appropriate era_action */
if (stat->flag & DEVSTAT_FLAG_SENSE_AVAIL ||
stat->dstat & ~(DEV_STAT_CHN_END | DEV_STAT_DEV_END)) {
/* anything abnormal ? */
if (device->discipline->examine_error == NULL ||
stat->flag & DEVSTAT_HALT_FUNCTION) {
era = dasd_era_fatal;
} else {
era = device->discipline->examine_error (cqr, stat);
}
DASD_DRIVER_DEBUG_EVENT (1, dasd_int_handler," era_code %d",
era);
}
Are you sure any parenthesises are not needed here?
-- Pete
next reply other threads:[~2001-11-08 20:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-08 20:57 Pete Zaitcev [this message]
2001-11-08 21:10 ` Kevin
2001-11-08 21:18 ` Jonathan Lundell
2001-11-08 21:28 ` Richard B. Johnson
2001-11-19 18:40 ` bill davidsen
2001-11-19 19:38 ` Peter T. Breuer
2001-11-21 6:57 ` Stevie O
2001-11-09 10:29 Carsten Otte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011108155749.A24023@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=Cotte@de.ibm.com \
--cc=Linux390@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®