From: Patrick Mansfield <patmans@us.ibm.com>
To: mbrown@emc.com (Michael F. Brown)
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix 2.4.14 scanning past LUN 7
Date: Fri, 9 Nov 2001 09:06:06 -0800 (PST) [thread overview]
Message-ID: <200111091706.fA9H66R17344@eng2.beaverton.ibm.com> (raw)
In-Reply-To: <20011109103435.A6848@lapi0061> from "Michael F. Brown" at Nov 09, 2001 09:34:35 AM PST
> > The setting of lun0_sl is broken in the current scsi_scan.c - if
> > we found a LUN 0, the just allocated SDpnt with a SDpnt->scsi_level
> > of 0 is used to set lun0_sl.
>
> While I think your change makes this cleaner, I don't see why the
> current code is broken. What difference does it make if
> lun0_sl is set after scan_scsis_single() or in scan_scsis_single()
> if in both cases it is set to SDpnt->scsi_level?
>
The problem is that if we find a device, a new SDpnt is allocated,
*SDpnt2 (SDpnt in scan_scsis()) is set to the new SDpnt, so
after scan_scsis_single() returns, SDpnt->scsi_level is 0, not
the value of the just found device.
The fix sets lun0_sl to the newly found devices SDpnt->scsi_level,
not to the newly allocated SDpnt->scsi_level.
--
Patrick Mansfield
prev parent reply other threads:[~2001-11-09 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-09 1:14 Patrick Mansfield
2001-11-09 15:34 ` Michael F. Brown
2001-11-09 17:06 ` Patrick Mansfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200111091706.fA9H66R17344@eng2.beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mbrown@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®