mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: barryn@pobox.com (Barry K. Nathan)
To: alan@lxorguk.ukuu.org.uk, viro@math.psu.edu,
	torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: [PATCH] 2.4.15-pre3 non-modular compile breakage
Date: Sun, 11 Nov 2001 21:09:29 -0800 (PST)	[thread overview]
Message-ID: <20011112050929.589FB89980@pobox.com> (raw)

It seems that Al Viro's patch to support large /proc/mounts, etc., has a
small mistake that broke (at least some) compiles where CONFIG_MODULES is
not defined... (That's the bug I reported to the list earlier tonight
FWIW.)

Here's a tested (on two systems, one with modules and one without) patch
against 2.4.15-pre3. The patch also seems to apply to 2.4.13-ac8, although
I have not tested it with that kernel version.

-Barry K. Nathan <barryn@pobox.com>

diff -ruN linux-2.4.15-pre3/fs/proc/proc_misc.c linux-2.4.15-pre3-bkn1/fs/proc/proc_misc.c
--- linux-2.4.15-pre3/fs/proc/proc_misc.c	Sun Nov 11 16:43:57 2001
+++ linux-2.4.15-pre3-bkn1/fs/proc/proc_misc.c	Sun Nov 11 20:32:11 2001
@@ -568,9 +568,11 @@
 	entry = create_proc_entry("mounts", 0, NULL);
 	if (entry)
 		entry->proc_fops = &proc_mounts_operations;
+#ifdef CONFIG_MODULES
 	entry = create_proc_entry("ksyms", 0, NULL);
 	if (entry)
 		entry->proc_fops = &proc_ksyms_operations;
+#endif
 	proc_root_kcore = create_proc_entry("kcore", S_IRUSR, NULL);
 	if (proc_root_kcore) {
 		proc_root_kcore->proc_fops = &proc_kcore_operations;

                 reply	other threads:[~2001-11-12  5:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011112050929.589FB89980@pobox.com \
    --to=barryn@pobox.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®