mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>
To: pellegrini@mpcnet.com.br (Jeronimo Pellegrini)
Cc: linux-kernel@vger.kernel.org, vojtech@suse.cz
Subject: Re: [PATCH] VIA timer fix was removed?
Date: Mon, 12 Nov 2001 15:48:24 +0100 (CET)	[thread overview]
Message-ID: <200111121448.PAA01060@green.mif.pg.gda.pl> (raw)
In-Reply-To: <20011112111409.A2617@socrates> from "Jeronimo Pellegrini" at Nov 12, 2001 11:14:09 AM

> The following patch (introduced by Vojtech Pavlik some time ago) was
> removed somewhere between 2.4.14 and 2.4.15-pre3.
> Without it, the timer counter is reset to a wrong value and
> gettimeofday() starts to return strange values
> 
> Nothing aboutit is mentioned in the changelog, so I suppose it wasn't
> supposed to be removed?

Maybe, it happens because somebody forgot to comment why this code is
necessary here ?
Just a guess...

> --- linux-2.4.15-pre3/arch/i386/kernel/time.c	Sun Nov 11 21:33:31 2001
> +++ linux-2.4.15-pre3-new/arch/i386/kernel/time.c	Mon Nov 12 10:45:57 2001
> @@ -501,6 +501,14 @@
>  
>  		count = inb_p(0x40);    /* read the latched count */
>  		count |= inb(0x40) << 8;
> +
> +		if (count > LATCH-1) {
> +			outb_p(0x34, 0x43);
> +		        outb_p(LATCH & 0xff, 0x40);
> +			outb(LATCH >> 8, 0x40);
> +			count = LATCH - 1;
> +		}
> +
>  		spin_unlock(&i8253_lock);

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk

  reply	other threads:[~2001-11-12 15:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-12 13:14 Jeronimo Pellegrini
2001-11-12 14:48 ` Andrzej Krzysztofowicz [this message]
2001-11-12 16:05   ` Jeronimo Pellegrini
2001-11-12 18:49   ` Nils Philippsen
2001-11-12 19:00     ` Jeronimo Pellegrini
2001-11-12 21:27       ` Neale Banks
2001-11-12 21:31         ` Alan Cox
2001-11-12 21:58           ` Vojtech Pavlik
2001-11-12 21:59           ` Neale Banks
2001-11-12 22:43             ` Alan Cox
2001-11-12 19:21     ` Nils Philippsen
     [not found] <20011119182927.A19179@suse.cz>
2002-04-08  6:33 ` Neale Banks
2002-04-08  7:24   ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200111121448.PAA01060@green.mif.pg.gda.pl \
    --to=ankry@green.mif.pg.gda.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pellegrini@mpcnet.com.br \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®