mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kuznet@ms2.inr.ac.ru
To: trond.myklebust@fys.uio.no
Cc: linux-kernel@vger.kernel.org
Subject: Re: more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5 client
Date: Tue, 20 Nov 2001 20:41:21 +0300 (MSK)	[thread overview]
Message-ID: <200111201741.UAA02990@ms2.inr.ac.ru> (raw)
In-Reply-To: <15353.28112.350734.11894@charged.uio.no> from "Trond Myklebust" at Nov 19, 1 09:38:40 pm

Hello!

> You are saying that the it is impossible for sock_alloc_send_skb() to
> fail when using non-blocking writes?

It is possible and normal provided frame is not fragmented.
And this is bug in nfsd if this happens with its frames.


> writes. (Note: by 'simultaneous' I mean that we don't wait for the
> server to reply before firing off the next request)

I do not understand, you have said you wait for write space yet. :-)


> I haven't done anything about this because IMHO it makes more sense to
> have the QDIO driver drop their special spinlock when calling external
> functions such as dev_kfree_skb_any() 

It is pretty normal, if I understand your words correctly.
kfree_skb() is called under various kinds of locks in lots of places.

> rather than to force the RPC layer to use the spin_lock_irqsave().

I see no relation at all. Do it irqsave and nothing will change,
write_space is called only from softirqs.

It is bug in xprt level to grab spinlock which can cause deadlocks
inside write_space. Probably, I misunderstood you.

Alexey

  parent reply	other threads:[~2001-11-20 17:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <15349.39320.876188.274548@charged.uio.no>
2001-11-15 21:29 ` nfs problem: hp-server --- linux 2.4.13 client, ooops Birger Lammering
2001-11-15 23:58   ` Trond Myklebust
2001-11-16 11:45     ` nfs problem: hp|aix-server --- linux 2.4.15pre5 client Trond Myklebust
2001-11-16 12:01       ` Miquel van Smoorenburg
2001-11-16 12:24         ` Trond Myklebust
2001-11-16 11:24   ` Birger Lammering
2001-11-16 13:19     ` nfs problem: aix-server " Birger Lammering
2001-11-19 10:20       ` IPV4 socket layer, was: " Birger Lammering
2001-11-19 11:16         ` Alan Cox
2001-11-19 18:22           ` more tcpdumpinfo for nfs3 " Trond Myklebust
2001-11-19 18:49             ` kuznet
2001-11-19 18:55             ` Trond Myklebust
2001-11-19 19:09               ` kuznet
2001-11-19 19:29               ` Trond Myklebust
2001-11-19 19:52                 ` kuznet
2001-11-19 20:38                 ` Trond Myklebust
2001-11-19 21:17                   ` Trond Myklebust
2001-11-20 17:42                     ` kuznet
2001-11-20 19:39                     ` Trond Myklebust
2001-11-20 19:45                       ` kuznet
2001-11-20 20:29                         ` Trond Myklebust
2001-11-21 10:07                         ` Trond Myklebust
2001-11-21 17:05                           ` kuznet
2001-11-20 20:05                       ` Trond Myklebust
2001-11-20 20:18                       ` David S. Miller
2001-11-20 20:28                         ` more tcpdumpinfo for nfs3 problem: aix-server --- linux kuznet
2001-11-20 17:41                   ` kuznet [this message]
2001-11-19 16:37         ` more tcpdumpinfo for nfs3 problem: aix-server --- linux 2.4.15pre5 client Birger Lammering
2001-11-20  9:26           ` Birger Lammering
2001-11-21 19:09 Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200111201741.UAA02990@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®