mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Phil Howard <phil-linux-kernel@ipal.net>
To: linux-kernel@vger.kernel.org
Subject: EINTR vs ERESTARTSYS, ERESTARTSYS not defined
Date: Thu, 22 Nov 2001 08:36:23 -0600	[thread overview]
Message-ID: <20011122083623.A18057@vega.ipal.net> (raw)

The accept() call does indeed return errno==ERESTARTSYS to user space
when coming back from signal handling, even though other things like
poll() return errno==EINTR.  This would not really be a problem except
for this in include/linux/errno.h starting at line 6:

+=============================================================================
| #ifdef __KERNEL__
| 
| /* Should never be seen by user programs */
| #define ERESTARTSYS     512
| #define ERESTARTNOINTR  513
| #define ERESTARTNOHAND  514     /* restart if no handler.. */
| #define ENOIOCTLCMD     515     /* No ioctl command */
+=============================================================================

So which way is it _supposed_ to be (so someone can patch things up
to make it consistent):

1.  User space should never see ERESTARTSYS from any system call

2.  ERESTARTSYS can be seen from system call and is defined somewhere

In user space I have to define __KERNEL__ to get programs to compile
when coded to know about all possible (valid?) values of errno from
system calls.  As seen from strace:

+=============================================================================
| [pid  6453] accept(5, 0xbffff908, [16]) = ? ERESTARTSYS (To be restarted)
| [pid  6453] --- SIGALRM (Alarm clock) ---
| [pid  6453] getppid()                   = 6452
| [pid  6453] gettimeofday({1006439405, 5879}, NULL) = 0
| [pid  6453] setitimer(ITIMER_REAL, {it_interval={0, 0}, it_value={9, 994121}}, NULL) = 0
| [pid  6453] rt_sigreturn(0x5)           = -1 EINTR (Interrupted system call)
| [pid  6453] accept(5, 0xbffff908, [16]) = ? ERESTARTSYS (To be restarted)
| [pid  6453] --- SIGALRM (Alarm clock) ---
| [pid  6453] getppid()                   = 6452
| [pid  6453] gettimeofday({1006439415, 6422}, NULL) = 0
| [pid  6453] setitimer(ITIMER_REAL, {it_interval={0, 0}, it_value={9, 993578}}, NULL) = 0
| [pid  6453] rt_sigreturn(0x5)           = -1 EINTR (Interrupted system call)
| [pid  6453] accept(5, 0xbffff908, [16]) = ? ERESTARTSYS (To be restarted)
+=============================================================================

-- 
-----------------------------------------------------------------
| Phil Howard - KA9WGN |   Dallas   | http://linuxhomepage.com/ |
| phil-nospam@ipal.net | Texas, USA | http://phil.ipal.org/     |
-----------------------------------------------------------------

             reply	other threads:[~2001-11-22 14:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-22 14:36 Phil Howard [this message]
2001-11-22 15:15 ` Andreas Schwab
2001-11-22 18:05   ` Phil Howard
2001-11-26 19:59 ` Alan Cox
     [not found] <20011122083623.A18057@vega.ipal.net.suse.lists.linux.kernel>
2001-11-22 15:28 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011122083623.A18057@vega.ipal.net \
    --to=phil-linux-kernel@ipal.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®