mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Alexander Viro <viro@math.psu.edu>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [CFT][PATCH] /proc/interrupts fixes
Date: Thu, 29 Nov 2001 15:46:11 +0300	[thread overview]
Message-ID: <20011129154611.A13470@jurassic.park.msu.ru> (raw)
In-Reply-To: <Pine.GSO.4.21.0111221823480.853-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0111221823480.853-100000@weyl.math.psu.edu>; from viro@math.psu.edu on Thu, Nov 22, 2001 at 06:36:44PM -0500

On Thu, Nov 22, 2001 at 06:36:44PM -0500, Alexander Viro wrote:
> 	Patch works on x86 and should work on every architecture where
> it manages to build.  Hopefully - all of them.  IOW, I've done the
> conversion for all architectures, but there could be typos.  Patch
> is very straightforward - see yourself.

Is /proc/interrupts now allowed only on s390, x86 and mips? ;-)
Also, typeof(x == y) is int, so (void *)(*pos == 0) on 64-bit
platforms produces a compiler warning.
With appended patch this compiles and works fine on alpha.
Thanks for cleaning up the /proc mess!

Ivan.

--- 2.5.1p3/fs/proc/proc_misc.c	Thu Nov 29 13:01:23 2001
+++ linux/fs/proc/proc_misc.c	Thu Nov 29 15:06:51 2001
@@ -318,7 +318,7 @@ static int partitions_read_proc(char *pa
 
 static void *single_start(struct seq_file *p, loff_t *pos)
 {
-	return (void *)(*pos == 0);
+	return NULL + (*pos == 0);
 }
 static void *single_next(struct seq_file *p, void *v, loff_t *pos)
 {
@@ -561,9 +561,7 @@ void __init proc_misc_init(void)
 		entry->proc_fops = &proc_kmsg_operations;
 	create_seq_entry("mounts", 0, &proc_mounts_operations);
 	create_seq_entry("cpuinfo", 0, &proc_cpuinfo_operations);
-#if defined(CONFIG_ARCH_S390) || defined(CONFIG_X86) || defined(CONFIG_ARCH_MIPS)
 	create_seq_entry("interrupts", 0, &proc_interrupts_operations);
-#endif
 #ifdef CONFIG_MODULES
 	create_seq_entry("ksyms", 0, &proc_ksyms_operations);
 #endif


  reply	other threads:[~2001-11-29 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-22 23:36 Alexander Viro
2001-11-29 12:46 ` Ivan Kokshaysky [this message]
2001-11-29 12:55   ` Christoph Hellwig
2001-11-29 13:18     ` Alexander Viro
2001-11-29 13:16   ` Alexander Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011129154611.A13470@jurassic.park.msu.ru \
    --to=ink@jurassic.park.msu.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®