From: Rick Lindsley <ricklind@us.ibm.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: "David C. Hansen" <haveblue@us.ibm.com>,
Linus Torvalds <torvalds@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove BKL from drivers' release functions
Date: Fri, 30 Nov 2001 12:11:35 -0800 [thread overview]
Message-ID: <200111302011.fAUKBZ408955@eng4.beaverton.ibm.com> (raw)
In-Reply-To: Your message of "Fri, 30 Nov 2001 04:57:28 EST." <Pine.GSO.4.21.0111300444180.13367-100000@weyl.math.psu.edu>
I think you're exactly the right person to be helping out with this;
glad to see you join the discussion.
The biggest flaw in the patch was not realizing that chrdev_open held
the BKL for us during opens as well. I don't think that invalidates it
in its entirety though. In cases where the patch replaced BKL with
some other form of locking, we should be no worse off (but for your
concerns about scheduling) because we added it in the open routines
too. In cases where we removed BKL from release but noted there were
"still" locking issues, yes, we need to examine those closely and fix
them in case we've created a locking issue where none existed before.
In most (all?) cases, the spinlocks are held briefly and (we believe)
not across scheduling opportunities. If you see areas of the patch
where that is not true, I agree they should be addressed and please point
them out.
Rick
prev parent reply other threads:[~2001-11-30 20:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-28 23:05 David C. Hansen
2001-11-28 23:29 ` Andrew Morton
2001-11-28 23:42 ` David C. Hansen
2001-11-28 23:50 ` Robert Love
2001-11-28 23:36 ` Alan Cox
2001-11-28 23:32 ` David C. Hansen
2001-11-28 23:45 ` Russell King
2001-11-29 0:26 ` David C. Hansen
2001-11-29 0:37 ` Jeff Garzik
2001-11-29 0:41 ` Russell King
2001-11-29 1:33 ` David C. Hansen
2001-11-29 1:42 ` Jeff Garzik
2001-11-29 7:17 ` Oliver Neukum
2001-11-29 1:47 ` Alan Cox
2001-11-29 9:15 ` Russell King
2001-11-29 13:55 ` BALBIR SINGH
2001-11-30 19:30 ` Rick Lindsley
2001-11-30 9:57 ` Alexander Viro
2001-11-30 12:41 ` Victor Yodaiken
2001-11-30 20:02 ` Rick Lindsley
2001-11-30 19:38 ` David C. Hansen
2001-11-30 23:12 ` Alexander Viro
2001-12-01 0:47 ` Rick Lindsley
2001-12-01 9:52 ` Alan Cox
2001-12-01 10:06 ` Rick Lindsley
2001-11-30 20:11 ` Rick Lindsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200111302011.fAUKBZ408955@eng4.beaverton.ibm.com \
--to=ricklind@us.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®