From: Ragnar Hojland Espinosa <ragnar@ragnar-hojland.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.16: kmalloc tidying
Date: Tue, 4 Dec 2001 00:02:21 +0100 [thread overview]
Message-ID: <20011204000221.B1034@ragnar-hojland.com> (raw)
In-Reply-To: <20011203193751.A10125@ragnar-hojland.com> <E16BBxS-0001Pn-00@the-village.bc.nu>
In-Reply-To: <E16BBxS-0001Pn-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Tue, Dec 04, 2001 at 09:33:46AM +0000
On Tue, Dec 04, 2001 at 09:33:46AM +0000, Alan Cox wrote:
> > +++ linux-2.4.16/drivers/sbus/char/envctrl.c Tue Nov 13 05:31:02 2001
> > @@ -897,10 +897,6 @@ static void envctrl_init_i2c_child(struc
> > }
> > =20
> > pchild->tables =3D kmalloc(tbls_size, GFP_KERNEL);
> > - if (!pchild->tables) {
> > - printk("envctrl: Failed to get table, not enough memory.\n");
>
> Why are you removing the checks here ?
Hrmpf.. reversed patch, I was actually adding them.
> > current->mm->rss =3D 0;
> > - setup_arg_pages(bprm); /* XXX: check error */
> > + retval =3D setup_arg_pages(bprm);
> > + if (retval)=20
> > + goto out_free_dentry;
>
> At this point you need to do more drastic things - see the last -ac patch
> for a possible solution
That does sound entertaining.. :)
--
____/| Ragnar Højland Freedom - Linux - OpenGL | Brainbench MVP
\ o.O| PGP94C4B2F0D27DE025BE2302C104B78C56 B72F0822 | for Unix Programming
=(_)= "Thou shalt not follow the NULL pointer for | (www.brainbench.com)
U chaos and madness await thee at its end."
prev parent reply other threads:[~2001-12-05 0:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-03 18:37 Ragnar Hojland Espinosa
2001-12-04 9:33 ` Alan Cox
2001-12-03 23:02 ` Ragnar Hojland Espinosa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011204000221.B1034@ragnar-hojland.com \
--to=ragnar@ragnar-hojland.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®