From: Jan Kara <jack@suse.cz>
To: Craig Christophel <merlin@transgeek.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: shrink_caches inconsistancy
Date: Thu, 6 Dec 2001 12:16:16 +0100 [thread overview]
Message-ID: <20011206121615.A21816@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20011205180526.DCB78C7382@smtp.transgeek.com>
In-Reply-To: <20011205180526.DCB78C7382@smtp.transgeek.com>
Hello,
> This patch makes the comments match for icache,dcache,dqcache shrink
> functions. Initially the comment stated that a priority of 0 could be used,
> but after looking into mm/vmscan.c::shrink_caches this cannot be true. So
> the comment now states that 1 is the highest priority. This appears __really
> true as at priority 1 all of the cache possible is removed.
>
> Also shrink_dqcache_memory now uses the count variable like everyone else.
>
> Possibly incorrect __GFP_FS check added to the dqcache function. but again
> consistancy is my goal.
This check really isn't needed for shrink_dqcache() function. This function can
never recurse into fs so there's no need to have __GFP_FS set.
> Another dqcache issue in that the dqcache was being shrunk at priority+1
> rather than at priority, this looked suspect, and with no comment around the
> code, it to has been remanded to consistancy.
OK :). If I remeber well I saw 'priority' could be 0 somewhere in the comment
and so I added +1 to avoid division by zero. But you're right that code in vmscan.c
actually never calls the functions with priority == 0.
Honza
next prev parent reply other threads:[~2001-12-06 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-05 22:09 Craig Christophel
2001-12-06 11:16 ` Jan Kara [this message]
2001-12-06 15:11 ` Craig Christophel
2001-12-05 22:49 Craig Christophel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011206121615.A21816@atrey.karlin.mff.cuni.cz \
--to=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=merlin@transgeek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®