From: kuznet@ms2.inr.ac.ru
To: Mika.Liljeberg@welho.com (Mika Liljeberg)
Cc: davem@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: TCP LAST-ACK state broken in 2.4.17-pre2
Date: Mon, 10 Dec 2001 21:34:47 +0300 (MSK) [thread overview]
Message-ID: <200112101834.VAA17862@ms2.inr.ac.ru> (raw)
In-Reply-To: <3C14FBE7.E3A5F745@welho.com> from "Mika Liljeberg" at Dec 10, 1 08:16:07 pm
Hello!
> Either LAST-ACK is completely broken or Linux just cannot handle a
> FIN-ACK that is piggybacked on a data segment, when received in LAST-ACK
> state.
It cannot handle even pure FIN in this state. :-( I bring apologies,
it is my fault. Thank you.
Well, you can just add one line to tcp_input.c to repair this.
}
/* Fall through */
+ case TCP_LAST_ACK:
case TCP_ESTABLISHED:
tcp_data_queue(sk, skb);
Dave, "official" patch will follow later. I must think about
some marginal effect in TCP_CLOSE_WAIT and TCP_CLOSING, which can break
out of switch too. Duh, do specs say something about segments with seqs
above fin? I do not remember.
Alexey
next prev parent reply other threads:[~2001-12-10 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-10 18:16 Mika Liljeberg
2001-12-10 18:34 ` kuznet [this message]
2001-12-10 18:54 ` Mika Liljeberg
2001-12-11 17:51 ` kuznet
2001-12-12 20:31 ` Mika Liljeberg
2001-12-13 17:59 ` kuznet
2001-12-13 19:30 ` Mika Liljeberg
2001-12-13 19:38 ` kuznet
2001-12-11 0:13 ` David S. Miller
2001-12-11 17:24 ` kuznet
2001-12-13 10:19 Pasi Sarolahti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200112101834.VAA17862@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=Mika.Liljeberg@welho.com \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®