mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
To: "David S. Miller" <davem@redhat.com>
Cc: linux-kernel@vger.kernel.org, axboe@suse.de
Subject: Re: that stupid aic7xxx AHC_NSEGS bug
Date: Thu, 13 Dec 2001 13:57:43 -0700	[thread overview]
Message-ID: <200112132057.fBDKvhg10748@aslan.scsiguy.com> (raw)
In-Reply-To: Your message of "Thu, 13 Dec 2001 12:42:05 PST." <20011213.124205.38323630.davem@redhat.com>

>
>We simply forget to initialize scb->sg_count in the non use_sg
>case, so if the previous usage of that scb has sg_count==AHC_NSEGS
>then we'd hit that panic erroneously.  Here is the fix below.

Which just goes to show you have useful Steve Lord's report was.
Even someone unfamiliar with the driver could figure this out once
someone bothered to provide decend debuggin info.

>"It can't possibly be my driver, something broke in some Linux
>subsystem which is making my driver break", sheesh get over it
>Justin...

That's a bit unfair David, and its also not an acurate quote.  I
did say to Nick Pasich, "I guarantee you though, it is not the aic7xxx
driver's fault" on 11/26, but ever since it became apparent that
I was wrong (11/29 perhaps?), I've been working with Nick to try
and reproduce the problem.  We all make mistakes David, even you.
Get over it. 8-)

--
Justin

  reply	other threads:[~2001-12-13 20:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-13 20:42 David S. Miller
2001-12-13 20:57 ` Justin T. Gibbs [this message]
2001-12-13 21:10 ` David S. Miller
2001-12-13 21:13   ` Justin T. Gibbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200112132057.fBDKvhg10748@aslan.scsiguy.com \
    --to=gibbs@scsiguy.com \
    --cc=axboe@suse.de \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®