From: "David C. Hansen" <haveblue@us.ibm.com>
To: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: [PATCH] remove redundant lock_kernel
Date: Mon, 17 Dec 2001 13:59:05 -0800 [thread overview]
Message-ID: <200112172159.fBHLx5a11340@localhost.localdomain> (raw)
In fs/proc/proc_misc.c:locks_read_proc(), the BKL is grabbed while calling get_locks_status(). But, this function holds the BKL for all of its list operations already. I know that the BKL can be held recursively, but I don't see any need for this extra lock. Patch against 2.5.1 attached.
--- linux-2.5.1/fs/proc/proc_misc.c Fri Dec 14 14:46:57 2001
+++ linux/fs/proc/proc_misc.c Mon Dec 17 13:45:49 2001
@@ -409,9 +409,7 @@
int count, int *eof, void *data)
{
int len;
- lock_kernel();
len = get_locks_status(page, start, off, count);
- unlock_kernel();
if (len < count) *eof = 1;
return len;
}
reply other threads:[~2001-12-17 21:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200112172159.fBHLx5a11340@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome