From: Legacy Fishtank <garzik@havoc.gtf.org>
To: Jason Thomas <jason@topic.com.au>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] link errors with internal calls to devexit functions
Date: Tue, 25 Dec 2001 12:56:37 -0500 [thread overview]
Message-ID: <20011225125637.A21718@havoc.gtf.org> (raw)
In-Reply-To: <20011222025725.GA629@topic.com.au>
In-Reply-To: <20011222025725.GA629@topic.com.au>; from jason@topic.com.au on Sat, Dec 22, 2001 at 01:57:25PM +1100
On Sat, Dec 22, 2001 at 01:57:25PM +1100, Jason Thomas wrote:
> please CC me I'm not on the list.
>
> This patch against 2.4.17 fixes internal calls to devexit functions (which
> is bypasses the devexit_p wrapper) in drivers/media/video/bttv-driver.c and
> drivers/usb/usb-uhci.c, they are the only two I found.
>
> diff -ur linux-2.4.17.orig/drivers/media/video/bttv-driver.c linux-2.4.17/drivers/media/video/bttv-driver.c
> --- linux-2.4.17.orig/drivers/media/video/bttv-driver.c Sat Dec 22 13:39:39 2001
> +++ linux-2.4.17/drivers/media/video/bttv-driver.c Sat Dec 22 13:46:02 2001
> @@ -2992,7 +2992,9 @@
> pci_set_drvdata(dev,btv);
>
> if(init_bt848(btv) < 0) {
> +#if defined(MODULE) || defined(CONFIG_HOTPLUG)
> bttv_remove(dev);
> +#endif
These changes are incorrect... if a remove function is called during the
init phase it should never have been marked __devexit in the first
place.
Jeff
next prev parent reply other threads:[~2001-12-25 17:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-22 2:57 Jason Thomas
2001-12-22 5:05 ` Keith Owens
2001-12-22 5:26 ` Andrew Morton
2001-12-22 9:04 ` Kai Germaschewski
2001-12-22 9:13 ` Keith Owens
2001-12-25 17:59 ` Legacy Fishtank
2001-12-25 17:56 ` Legacy Fishtank [this message]
2002-01-09 4:40 Jason Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011225125637.A21718@havoc.gtf.org \
--to=garzik@havoc.gtf.org \
--cc=jason@topic.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®