From: Legacy Fishtank <garzik@havoc.gtf.org>
To: Daniel Phillips <phillips@bonn-fries.net>
Cc: linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net,
Arnaldo Carvalho de Melo <acme@conectiva.com.br>,
Alexander Viro <viro@math.psu.edu>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [RFC] [PATCH] Clean up fs.h union for ext2
Date: Wed, 26 Dec 2001 22:28:09 -0500 [thread overview]
Message-ID: <20011226222809.A8233@havoc.gtf.org> (raw)
In-Reply-To: <E16JR71-0000cU-00@starship.berlin>
In-Reply-To: <E16JR71-0000cU-00@starship.berlin>; from phillips@bonn-fries.net on Thu, Dec 27, 2001 at 04:21:42AM +0100
On Thu, Dec 27, 2001 at 04:21:42AM +0100, Daniel Phillips wrote:
> --- ../2.4.17.clean/include/linux/fs.h Fri Dec 21 12:42:03 2001
> +++ ./include/linux/fs.h Wed Dec 26 23:30:55 2001
> @@ -478,7 +478,7 @@
> __u32 i_generation;
> union {
> struct minix_inode_info minix_i;
> - struct ext2_inode_info ext2_i;
> + struct ext2_inode_info ext2_inode_info;
> struct ext3_inode_info ext3_i;
> struct hpfs_inode_info hpfs_i;
> struct ntfs_inode_info ntfs_i;
Change in principle looks good except IMHO you should go ahead and
remove the ext2 stuff from the union... (with the additional changes
that implies)
Jeff
next prev parent reply other threads:[~2001-12-27 3:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-27 3:21 Daniel Phillips
2001-12-27 3:28 ` Legacy Fishtank [this message]
2001-12-27 3:35 ` Arnaldo Carvalho de Melo
2001-12-27 3:52 ` Daniel Phillips
2002-01-05 14:56 ` Anton Altaparmakov
2002-01-06 3:32 ` Daniel Phillips
2002-01-07 0:30 ` Anton Altaparmakov
2002-01-07 1:27 ` Arnaldo Carvalho de Melo
2002-01-07 2:12 ` Daniel Phillips
2002-01-07 2:18 ` Arnaldo Carvalho de Melo
2002-01-07 2:22 ` Arnaldo Carvalho de Melo
2001-12-27 18:14 ` [Ext2-devel] " Andreas Dilger
2001-12-28 1:55 ` Daniel Phillips
2001-12-29 16:04 ` Oliver Xymoron
2001-12-29 21:01 ` Andreas Dilger
2001-12-29 21:30 ` Oliver Xymoron
2001-12-29 21:08 ` Andrew Morton
2002-01-02 10:26 ` Pavel Machek
2002-01-05 14:29 ` Anton Altaparmakov
2002-01-05 14:47 ` Daniel Phillips
2002-01-06 4:04 ` Anton Altaparmakov
2002-01-06 22:42 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011226222809.A8233@havoc.gtf.org \
--to=garzik@havoc.gtf.org \
--cc=acme@conectiva.com.br \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=phillips@bonn-fries.net \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome