From: andersg@0x63.nu
To: linux-kernel@vger.kernel.org
Cc: reiserfs-dev@namesys.com, torvalds@transmeta.com
Subject: [PATCH] reiserfs oneliner
Date: Fri, 28 Dec 2001 18:42:44 +0100 [thread overview]
Message-ID: <20011228174244.GD20899@h55p111.delphi.afb.lu.se> (raw)
This patch removes an assignment in super.c in reiserfs that caused deadlock
when mounting my reiser-filesystems.
the original code looks like this:
size = block_size(s->s_dev);
sb_set_blocksize(s, size);
/* read block (64-th 1k block), which can contain reiserfs super block */
if (read_super_block (s, REISERFS_DISK_OFFSET_IN_BYTES)) {
// try old format (undistributed bitmap, super block in 8-th 1k block of a device)
sb_set_blocksize(s, size);
if (read_super_block (s, REISERFS_OLD_DISK_OFFSET_IN_BYTES))
goto error;
else
old_format = 1;
}
s->s_blocksize = size;
If read_super_block() changes the blocksize in the superblock it shouldn't
be restored again, should it?
With the following patch i can mount my reiserfs:es without deadlock.
--- linux-2.5.2-pre3/fs/reiserfs/super.c Fri Dec 28 09:03:32 2001
+++ linux-2.5.2-pre3-lvmfix-reiserfix/fs/reiserfs/super.c Fri Dec 28 18:19:49 2001
@@ -637,7 +637,6 @@
else
old_format = 1;
}
- s->s_blocksize = size;
s->u.reiserfs_sb.s_mount_state = SB_REISERFS_STATE(s);
s->u.reiserfs_sb.s_mount_state = REISERFS_VALID_FS ;
reply other threads:[~2001-12-28 17:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011228174244.GD20899@h55p111.delphi.afb.lu.se \
--to=andersg@0x63.nu \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®