mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Summit support for 2.5 - now with subarch! [4/5]
Date: Mon, 14 Oct 2002 16:35:12 -0700	[thread overview]
Message-ID: <2001880782.1034613312@[10.10.2.3]> (raw)
In-Reply-To: <200210142311.g9ENB9m04835@localhost.localdomain>

>> +       summit_check(oem, str);
> 
> This is more a type check hook.  Since it might potentially be used to catch 
> other machine types, shouldn't it have a more generic name 
> (mptable_string_hook or something)?

OK, I can change that.

>> +int summit_x86 = 0;
> 
> This should really be in a .c file in mach-summit.  I know a single line file 
> with just a variable in it is a bit strange, but the principle of the subarch 
> stuff is to have anything subarch specific (which this is) in mach-<subarch>.

That's pretty pointless for one variable. I think you're taking things
to ridiculous extremes.

M.



  reply	other threads:[~2002-10-14 23:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-14 23:11 James Bottomley
2002-10-14 23:35 ` Martin J. Bligh [this message]
2002-10-15  0:17   ` Martin J. Bligh
2002-10-15 17:30   ` James Bottomley
2002-10-15 17:32     ` Martin J. Bligh
  -- strict thread matches above, loose matches on Subject: below --
2002-10-14 22:27 Martin J. Bligh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='2001880782.1034613312@[10.10.2.3]' \
    --to=mbligh@aracnet.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®