From: "Adam J. Richter" <adam@yggdrasil.com>
To: linux-kernel@vger.kernel.org, akpm@zip.com.au
Subject: Patch?: linux-2.5.2-pre8/fs/ext3/super.c - variation of fix by Andrew Morton
Date: Sat, 5 Jan 2002 04:35:06 -0800 [thread overview]
Message-ID: <20020105043506.A24538@baldur.yggdrasil.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
Andrwe Morton posted a fix for the compilation error in
linux-2.5.2-pre8/fs/ext3/super.c. I have changed his test to
use "!kdev_none()" instead of "!kdev_val()". It will compile
to the same opcodes, but I think this way is slightly more proper.
It may even make a difference some day if the internal representation
of kdev_val or kdev_none changes in a weird way so that
kdev_val(NODEV) returns non-zero, although I think this is unlikely.
--
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
adam@yggdrasil.com \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."
[-- Attachment #2: ext3.diff --]
[-- Type: text/plain, Size: 396 bytes --]
--- linux-2.5.2-pre8/fs/ext3/super.c Fri Jan 4 19:40:37 2002
+++ linux/fs/ext3/super.c Sat Jan 5 04:29:20 2002
@@ -56,10 +56,10 @@
static void make_rdonly(kdev_t dev, int *no_write)
{
- if (dev) {
+ if (!kdev_none(dev)) {
printk(KERN_WARNING "Turning device %s read-only\n",
bdevname(dev));
- *no_write = 0xdead0000 + dev;
+ *no_write = 0xdead0000 + kdev_val(dev);
}
}
next reply other threads:[~2002-01-05 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-05 12:35 Adam J. Richter [this message]
2002-01-05 19:07 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020105043506.A24538@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®