From: Andreas Dilger <adilger@turbolabs.com>
To: Zwane Mwaikambo <zwane@linux.realnet.co.sz>
Cc: Jens Axboe <axboe@suse.de>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Oops with eject and cdrom affects 2.4 & 2.5
Date: Wed, 9 Jan 2002 02:32:43 -0700 [thread overview]
Message-ID: <20020109023243.G769@lynx.adilger.int> (raw)
In-Reply-To: <20020109091217.K19814@suse.de> <Pine.LNX.4.33.0201091023380.8076-100000@netfinity.realnet.co.sz>
In-Reply-To: <Pine.LNX.4.33.0201091023380.8076-100000@netfinity.realnet.co.sz>; from zwane@linux.realnet.co.sz on Wed, Jan 09, 2002 at 11:07:33AM +0200
On Jan 09, 2002 11:07 +0200, Zwane Mwaikambo wrote:
> On Wed, 9 Jan 2002, Jens Axboe wrote:
> > Yes, just kill the printk instead.
>
> Here are patches for 2.5.2-pre10 and 2.4.18-pre2 respectively
>
> --- linux-2.5.2-pre10/drivers/ide/ide-cd.c.orig Wed Jan 9 10:18:40 2002
> +++ linux-2.5.2-pre10/drivers/ide/ide-cd.c Wed Jan 9 10:28:22 2002
> @@ -1398,11 +1398,8 @@
> ide_init_drive_cmd (&req);
> req.flags = REQ_PC;
> req.special = (char *) pc;
> - if (ide_do_drive_cmd (drive, &req, ide_wait)) {
> - printk("%s: do_drive_cmd returned stat=%02x,err=%02x\n",
> - drive->name, req.buffer[0], req.buffer[1]);
> - /* FIXME: we should probably abort/retry or something */
> - }
> + ide_do_drive_cmd (drive, &req, ide_wait);
> +
Hmm, it would appear that this patch is "losing information", about the
fact that there could be an error here, and the FIXME that it should be
retried. If anything, I would just remove the printk and leave the FIXME.
Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/
prev parent reply other threads:[~2002-01-09 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-09 6:12 Zwane Mwaikambo
2002-01-09 8:12 ` Jens Axboe
2002-01-09 9:07 ` Zwane Mwaikambo
2002-01-09 9:32 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020109023243.G769@lynx.adilger.int \
--to=adilger@turbolabs.com \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=zwane@linux.realnet.co.sz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®