From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Linus Torvalds <torvalds@transmeta.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Jeff Garzik <jgarzik@mandrakesoft.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Steven Walter <srwalter@yahoo.com>
Subject: Re: [PATCH] wavelan: check request_region return value
Date: Wed, 9 Jan 2002 14:29:51 -0800 [thread overview]
Message-ID: <20020109142951.A10219@bougret.hpl.hp.com> (raw)
In-Reply-To: <20011230172229.M24320@hapablap.dyn.dhs.org>
In-Reply-To: <20011230172229.M24320@hapablap.dyn.dhs.org>; from srwalter@yahoo.com on Sun, Dec 30, 2001 at 05:22:29PM -0600
On Sun, Dec 30, 2001 at 05:22:29PM -0600, Steven Walter wrote:
> I recently changed several drivers in drivers/net of the Linux kernel to
> correctly check the return value of request_region. Since you appear
> to be the maintainer of this driver, I'm forwarding the patch to you.
>
> Thanks
> --
> -Steven
For some reason, the tab got mangled, so I redid the
patch. Ready to go in kernel 2.4.X and 2.5.X.
Jean
diff -u -p linux/drivers/net/wavelan.j1.c linux/drivers/net/wavelan.c
--- linux/drivers/net/wavelan.j1.c Wed Jan 9 14:23:19 2002
+++ linux/drivers/net/wavelan.c Wed Jan 9 14:25:04 2002
@@ -4019,7 +4019,8 @@ static int __init wavelan_config(device
dev->irq = irq;
- request_region(ioaddr, sizeof(ha_t), "wavelan");
+ if (!request_region(ioaddr, sizeof(ha_t), "wavelan"))
+ return -EBUSY;
dev->mem_start = 0x0000;
dev->mem_end = 0x0000;
parent reply other threads:[~2002-01-09 22:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20011230172229.M24320@hapablap.dyn.dhs.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020109142951.A10219@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=jgarzik@mandrakesoft.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=srwalter@yahoo.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®