From: David Weinehall <tao@acc.umu.se>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Benjamin LaHaise <bcrl@redhat.com>, John Weber <weber@nyc.rr.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: 2.5.3-pre1 compile error
Date: Wed, 16 Jan 2002 01:38:11 +0100 [thread overview]
Message-ID: <20020116013811.E5235@khan.acc.umu.se> (raw)
In-Reply-To: <20020115192048.G17477@redhat.com> <Pine.LNX.4.33.0201151628440.1140-100000@penguin.transmeta.com>
In-Reply-To: <Pine.LNX.4.33.0201151628440.1140-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Tue, Jan 15, 2002 at 04:29:38PM -0800
On Tue, Jan 15, 2002 at 04:29:38PM -0800, Linus Torvalds wrote:
>
> On Tue, 15 Jan 2002, Benjamin LaHaise wrote:
> >
> > Hmm, this should fix that.
>
> probably will, BUT..
>
> > +#ifndef __ASM__ATOMIC_H
> > +#include <asm/atomic.h>
> > +#endif
>
> Please do not assume knowdledge of what the different header files use to
> define their re-entrancy.
>
> Just do
>
> #include <asm/atomic.h>
>
> and be done with it.
The lines below say:
#ifndef _LINUX_POSIX_TYPES_H /* __FD_CLR */
#include <linux/posix_types.h>
#endif
Maybe fix this while at it?!
/David
_ _
// David Weinehall <tao@acc.umu.se> /> Northern lights wander \\
// Maintainer of the v2.0 kernel // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </
next prev parent reply other threads:[~2002-01-16 0:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-16 0:05 John Weber
2002-01-16 0:20 ` [PATCH] " Benjamin LaHaise
2002-01-16 0:29 ` Linus Torvalds
2002-01-16 0:38 ` David Weinehall [this message]
2002-01-16 0:41 ` Linus Torvalds
2002-01-16 0:55 ` Dave Jones
2002-01-16 2:10 ` dmeyer
2002-01-16 18:32 ` Peter Osterlund
2002-01-16 0:43 ` Benjamin LaHaise
2002-01-16 0:44 ` Linus Torvalds
2002-01-16 0:52 ` Benjamin LaHaise
2002-01-16 1:18 ` David Weinehall
2002-01-17 22:11 ` Christopher Turcksin
2002-01-16 0:46 ` Davide Libenzi
2002-01-16 0:43 ` Linus Torvalds
2002-01-16 1:17 ` Davide Libenzi
2002-01-16 1:23 ` Davide Libenzi
2002-01-16 0:52 ` David S. Miller
2002-01-16 1:06 ` Andre Hedrick
2002-01-16 1:24 ` Robert Love
2002-01-16 1:25 ` Benjamin LaHaise
2002-01-16 1:39 ` Robert Love
[not found] <20020115194425.J17477@redhat.com>
2002-01-16 0:52 ` Davide Libenzi
2002-01-16 1:16 ` David Weinehall
2002-01-16 1:24 ` Davide Libenzi
[not found] <fa.oa9ld7v.gk65b0@ifi.uio.no>
[not found] ` <fa.g97h3fv.968725@ifi.uio.no>
2002-01-16 4:59 ` Russ Allbery
[not found] <20020115192048.G17477@redhat.com.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.33.0201151628440.1140-100000@penguin.transmeta.com.suse.lists.linux.kernel>
2002-01-16 11:27 ` Andi Kleen
2002-01-16 11:39 ` Dave Jones
2002-01-17 7:40 ` Neil Booth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020116013811.E5235@khan.acc.umu.se \
--to=tao@acc.umu.se \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=weber@nyc.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®