From: Troy Benjegerdes <hozer@drgw.net>
To: "David S. Miller" <davem@redhat.com>,
linux-kernel@vger.kernel.org, Gerard Roudier <groudier@free.fr>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Russell King <rmk@arm.linux.org.uk>,
Dan Malek <dan@embeddededge.com>,
mattl@mvista.com
Subject: pci_alloc_consistent from interrupt == BAD
Date: Fri, 18 Jan 2002 13:02:09 -0600 [thread overview]
Message-ID: <20020118130209.J14725@altus.drgw.net> (raw)
Somehow the docs in DMA-mappings.txt say pci_alloc_consistent is allowed from
interrupt, but this is a "bad thing" on at least arm and PPC non-cache
coherent cpus.
On these cpus we have to allocate page tables for consistent_alloc.. I really
dont' think we want to be doing this during interrupt context.
This also causes the sym53c8xx_2 driver to not work on some embedded ppc 4xx
boards, and in general, seems to be a 'bad thing' to allow.
For example, in the arch/arm/consistent.c:
/*
* This allocates one page of cache-coherent memory space and returns
* both the virtual and a "dma" address to that space. It is not clear
* whether this could be called from an interrupt context or not. For
* now, we expressly forbid it, especially as some of the stuff we do
* here is not interrupt context safe.
*
* Note that this does *not* zero the allocated area!
*/
void *consistent_alloc(int gfp, size_t size, dma_addr_t *dma_handle)
(arm's pci_alloc_consistent always calls consistent_alloc).
The PPC version calls a similiar function when CONFIG_NOT_COHERENT_CACHE is
defined. On 'regular' ppc machines, it's just a __get_free_pages, which is
why no one from the pmac crowd has screamed.
--
Troy Benjegerdes | master of mispeeling | 'da hozer' | hozer@drgw.net
-----"If this message isn't misspelled, I didn't write it" -- Me -----
"Why do musicians compose symphonies and poets write poems? They do it
because life wouldn't have any meaning for them if they didn't. That's
why I draw cartoons. It's my life." -- Charles Schulz
next reply other threads:[~2002-01-18 19:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1011386221.24072.linux-kernel2news@redhat.com>
2002-01-18 19:02 ` Troy Benjegerdes [this message]
2002-01-18 19:22 ` Dan Malek
2002-01-18 20:50 ` Gérard Roudier
2002-01-21 23:52 ` Pete Zaitcev
2002-01-18 20:21 ` Gérard Roudier
2002-01-18 20:32 ` David S. Miller
2002-01-18 21:29 ` Russell King
2002-01-18 21:46 ` Dan Malek
2002-01-18 21:55 ` Russell King
2002-01-18 22:13 ` Dan Malek
2002-01-18 21:33 ` David S. Miller
2002-01-18 21:42 ` Russell King
2002-01-18 21:43 ` Dan Malek
2002-01-18 20:38 ` David S. Miller
2002-01-18 21:07 ` Gérard Roudier
2002-01-18 21:13 ` David S. Miller
2002-01-22 0:08 ` David S. Miller
2002-01-22 0:20 ` Pete Zaitcev
2002-01-19 17:21 David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020118130209.J14725@altus.drgw.net \
--to=hozer@drgw.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dan@embeddededge.com \
--cc=davem@redhat.com \
--cc=groudier@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mattl@mvista.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®