From: "Roger W.Brown" <bregor@anusf.anu.edu.au>
To: linux-kernel@vger.kernel.org
Subject: Type-change of kdev_t
Date: Sat, 19 Jan 2002 00:42:44 +1100 (EST) [thread overview]
Message-ID: <20020118134245.630F6706B1@argo.anu.edu.au> (raw)
Hi,
I'm no kernel hacker so I am little hesitant to speak; however,
I'm looking at kdev_t.h from the linux-2.5.3-pre1 source.
The type of kdev_t has changed recently from a scalar type to a
structured type. Should macro definitions such as MINOR(dev) also
be revised to be consistent with the "new" kdev_t ?
Something like:
#define MINOR(dev) ((unsigned int) ((dev.value) & MINORMASK))
rather than
#define MINOR(dev) ((unsigned int) ((dev) & MINORMASK))
Then usage of the MINOR() macro remains unchanged.
Regards,
Roger Brown
next reply other threads:[~2002-01-18 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-18 13:42 Roger W.Brown [this message]
2002-01-18 16:39 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020118134245.630F6706B1@argo.anu.edu.au \
--to=bregor@anusf.anu.edu.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®