From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.linuxppc.org>,
Lukas Geyer <geyer@ml.kva.se>
Subject: Re: 2.4.18pre4 on PPC, Byteswap in dmasound_awacs.c
Date: Sat, 19 Jan 2002 17:18:19 +0100 [thread overview]
Message-ID: <20020119161819.5536@smtp.wanadoo.fr> (raw)
In-Reply-To: <Pine.LNX.4.33.0201191547510.6868-100000@cauchy.ml.kva.se>
In-Reply-To: <Pine.LNX.4.33.0201191547510.6868-100000@cauchy.ml.kva.se>
>My Keylargo controller reports 0 as the revision number, thus it might
>either be advisable to put that hw_can_byteswap = 0 into the innermost
>block and not check the revision at all (if no Keylargo can do byteswap)
>or or to put a check for revision <= 2 (after all, isn't it logical to
>assume that only later revisions will be able to do byteswap?) inside the
>innermost block and set hw_can_byteswap to 0 there.
You are right, this is a pangea chipset (KeyLargo & UniNorth in a
single ASIC) and in that case, KL provides no rev. number. I'll fix
this.
Thanks for the report,
Ben.
prev parent reply other threads:[~2002-01-19 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-19 15:11 Lukas Geyer
2002-01-19 16:18 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020119161819.5536@smtp.wanadoo.fr \
--to=benh@kernel.crashing.org \
--cc=geyer@ml.kva.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®